Open
Conversation
473b650 to
ddac399
Compare
tianyu-l
approved these changes
Mar 12, 2026
pianpwk
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MXFP8WeightWrapperTensor(Dtensor(...))([TP] reorder MXFP8 wrapper over DTensor ao#4010) and landing Dtensor scaled_mm sharding strategy fixes ([DTensor] fix scaled_mm sharding strategy pytorch#177234).Dtensor(MXFP8WeightWrapperTensor(..)), we need to warn that linears using TP will use default precision, not MXFP8.Optional extra details
aten.t+aten.mm, going straight through__torch_dispatch__instead of first going through__torch_function__. This prevents our subclass from intercepting the linear op to dispatch to_to_mxfp8_then_scaled_mmautograd func. We cannot intercept at the__torch_dispatch__level because then autograd would not capture the backward for our autograd func we dispatch to.aten._grouped_mmin__torch_function__and can intercept.