[v26.1.x] redpanda: don't error on unknown property removal in admin_server::patch_cluster_config_handler()#30060
Merged
WillemKauf merged 2 commits intoredpanda-data:v26.1.xfrom Apr 3, 2026
Conversation
... `admin_server::patch_cluster_config_handler()`
For example, If I put an unknown property into the `config_cache.yaml`
or directly force it through the AdminAPI with a command like
```
curl -X PUT 'http://localhost:9644/v1/cluster_config?force=true' \
-H 'Content-Type: application/json' \
-d '{"upsert": {"my_fake_property": "true"}, "remove": []}'
```
Then it will be persisted to the configuration system via the
`config_cache.yaml`, as well as the controller log/snapshots.
```
willem@bloom:~/redpanda$ rpk cluster config status
NODE CONFIG-VERSION NEEDS-RESTART INVALID UNKNOWN
0 24 false [] [my_fake_property]
1 24 false [] [my_fake_property]
2 24 false [] [my_fake_property]
```
Up till now, an admin API deletion request would be unable to remove
this without `?force=true`, instead returning an error:
```
$ curl -X PUT 'http://localhost:9644/v1/cluster_config' \
-H 'Content-Type: application/json' \
-d '{"upsert": {}, "remove": ["my_fake_property"]}'
{"my_fake_property":"Unknown property"}
```
We can choose to be silent about this instead, for the property we may
be attempting to remove (very validly without removing guardrails in place
via `?force=true`) _could_ be one of these unknown properties.
Remove erroring on this path and instead apply the update.
(cherry picked from commit a6fee11)
(cherry picked from commit 725cec7)
WillemKauf
approved these changes
Apr 3, 2026
Collaborator
Author
CI test resultstest results on build#82711
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30054