Add table support to OSS server#11356
Conversation
timsaucer
added
include in changelog
dataplatform
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
"Blocked" on #11361 ;) |
abey79
left a comment
abey79
left a comment
There was a problem hiding this comment.
Great stuff! I've left a bunch of comments, some of which might be out of scope. I'll let you judge :)
| { name = "cargo_metadata" }, # Older version used by ply-rs. It's small, and it's build-time only! | ||
| { name = "core-foundation" }, # Currently, e.g. `webbrowser` and `winit` use different versions. | ||
| { name = "core-graphics-types" }, # wgpu requires 0.2 while winit is still on 0.1 | ||
| { name = "event-listener" }, # remove after https://github.com/lancedb/lance/pull/4834 closes |
There was a problem hiding this comment.
again, by using #TODO(#issue) format, it gets picked up by our zombie todo script
There was a problem hiding this comment.
I don't think adding an issue to track this one is necessary since CI will fail as soon as the exception is no longer encountered
| &self, | ||
| _request: tonic::Request<RegisterTableRequest>, | ||
| ) -> Result<tonic::Response<RegisterTableResponse>, tonic::Status> { | ||
| Err(tonic::Status::unimplemented( | ||
| "register_table not implemented", | ||
| )) | ||
| } |
There was a problem hiding this comment.
Any chance for a quick stab at this? This PR would love it :)
2 participants
This PR adds support for lance tables in the OSS server, similar to the existing support for Rerun datasets.
Users can add a
--table file_pathoption to provide a path to the table location.Additionally it creates the
__entriestable that is required for using the dataframe APIs.Unit tests were updated and verified to match the redap server.
This is an enabling feature for ongoing work such as catalog providers where we need to use the OSS server in CI.