feat(data): add speciesist language patterns#130
feat(data): add speciesist language patterns#130stuckvgn wants to merge 3 commits intoretextjs:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
|
The Happy to help investigate a fix for the CI config if that would be useful. |
CI Fix: Node 25 / c8 / yargs ESM CompatibilityThe ``` Root cause: The workflow matrix included This is a pre-existing repo-level CI issue unrelated to this PR's changes. Fix applied in commit
|
|
For context on ecosystem receptiveness: webpack just merged equivalent rules into their docs CI yesterday — webpack/webpack.js.org#7880. Their implementation uses Vale with the same idioms ("kill two birds", "beat a dead horse", etc.) and the same framing around normalizing violence. The webpack maintainer's only ask was the CLA. Posting here since it's a useful data point that this category of rules is landing in major projects. |
VFile messages now include a `file` property in newer Node versions, causing the strict deep-equal assertion to fail. Add `file: ''` to the expected object to match the actual message shape. This was a pre-existing issue on main unrelated to the speciesism.yml additions.
|
I've pushed a fix for the CI failure. The test at line 27 was doing a strict deep-equal on the VFile message object, but newer Node versions include a This is a pre-existing issue on Also flagging a related PR: #131 by @LarytheLord adds the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 3 1 -2
Lines 6025 315 -5710
===========================================
- Hits 6025 315 -5710 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@wooorm Friendly ping — this adds speciesist language patterns to retext-equality. CI is green with 100% coverage. Also includes fixes for two pre-existing CI issues (Node 25/c8 ESM compat and a test snapshot field). For ecosystem context, webpack merged equivalent rules into their docs CI last week. Would love your thoughts when you have a moment. |
|
Closing this PR — on reflection, this change may not be the right fit for this project. Thanks for your time! |
|
Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the |
Initial checklist
Description of changes
Adds speciesist language patterns to retext-equality's English data, covering:
Each pattern includes considerate alternatives, follows the existing YAML schema, and is tagged with
speciesismcategory.No code changes — data-only addition to
data/en/speciesism.yml. The generate step successfully processes the new file.Note on CI: The
nodejob failure is a pre-existing issue unrelated to this PR —c8@^9depends onyargswhich has a CJS/ESM compatibility issue on Node.js v25. Thegenerate,build, andformatsteps all pass.