feat: add rule for 'kill two birds with one stone' idiom#131
feat: add rule for 'kill two birds with one stone' idiom#131LarytheLord wants to merge 3 commits intoretextjs:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
|
Pushed one more follow-up commit: 7aa458a.\n\nI narrowed the coverage tooling pin to c8 7.3.0 (which uses yargs 15) to avoid the Node 25 ESM/CJS runtime break seen in CI. Local validation still passes with npm test. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 3 1 -2
Lines 6025 315 -5710
===========================================
- Hits 6025 315 -5710 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Leaving a note here since this PR and #130 are closely related — both address issues that are blocking speciesism language pattern support from getting merged. #130 adds the actual speciesism pattern data ( The c8/Node 25 fix you've made here would also need to be applied to the #130 branch. If it's easier, these could potentially be combined into one PR. Either way, cross-linking for reviewer visibility — both touch the same CI infrastructure and both are part of the same effort to expand the pattern set. For what it's worth, this kind of speciesism language guidance is gaining traction: webpack just merged similar rules to their Vale linting config on Feb 25, 2026 (webpack/webpack.js.org#7880). Having it in retext-equality means it propagates automatically to alex and any downstream tool that uses this package. |
|
Thanks for cross-linking this. Agreed these are related efforts.\n\nI’ve kept this PR scoped to the idiom rule + CI compatibility update on this branch; #130 can apply the same c8 pin strategy if that branch still hits the Node 25 runtime mismatch.\n\nIf maintainers prefer, I can also split out the CI pin into a tiny dedicated PR for easier reuse/cherry-pick across both branches. |
Initial checklist
Description of changes
Add one new
miscrule for the idiomkill two birds with one stone.solve two problems at onceachieve two goals at oncetest.jsrules.md(new rule table row)Validation:
npm run generatenode --conditions development test.js