Repository navigation
fix(cli): explain an engine that runs without the agentmemory worker - #1758
Conversation
When only the iii engine runs on the REST port, the agentmemory routes return 404. Status printed version v? and Health unknown, and the viewer returned 404, with no hint about the cause. Old Docker images from the legacy CLI Docker mode ran only the engine and showed this state. Status now probes /agentmemory/livez and /agentmemory/health. When both return 404, it says that the engine runs without the worker, how to start agentmemory, and where the Docker migration guide is. Doctor has a new worker-not-connected check with the same fix text. Every failing doctor check now prints its message and a fix hint, not only its id. The iii-on-path-not-local-bin check now says which iii is used, its version, and the command to run. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough
Merge Risk:
|
When a supervised worker in the managed Compose project exhausts its restarts, the agentmemory routes can return 404. The engine-only probe then exited before status printed the Compose failure. Skip the probe for managed Compose state in status and doctor; it is meant for engines agentmemory does not manage. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
Two 404 responses from the agentmemory routes no longer prove an iii engine. The probe now also checks the engine port. If that port does not answer, status and doctor report an unrecognized service and do not tell the user to stop it. Status and doctor now probe the selected target also when managed Compose state exists. Status prints the Compose failure report first when there is one. Doctor reports a managed Compose engine without its worker and no longer passes for a remote URL or another port. The recovery command keeps --instance, --port and --data-dir. The iii-on-path-not-local-bin message no longer says that startup uses the PATH iii. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
|
Review-body findings, handled in c02a4e4:
|
When a managed Compose worker exhausted its restarts, the agentmemory routes answer 404 and status exited with the engine-only message. Status now continues to the normal report, which lists the Compose failure, as it did before. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
Status and doctor recovery commands now keep --instance, --port and a shell-quoted --data-dir for status, stop and start. A route that fails next to a 404 no longer counts as a connected worker. Status exits 1 when the worker routes do not respond. The engine bus probe honors III_URL when III_ENGINE_URL is unset. The doctor message no longer claims an engine is running, and the unrecognized-service hint points old Docker images at the migration guide. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
On Windows the recovery hint now puts --data-dir in PowerShell single quotes, so dollar signs and apostrophes stay literal. Trailing path separators are dropped, so no backslash comes before a closing quote. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
A drive root such as C:/ keeps its separator in recovery hints. Windows paths that need quoting use double quotes, which Command Prompt and PowerShell both read literally. Paths with a dollar sign keep PowerShell single quotes. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
|
@codex review |
Resolve the src/cli.ts import conflict by keeping the worker-connection import from this branch and the hook-capture status imports from #1756. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
When only the iii engine runs (for example an old Docker image), the agentmemory routes return 404 and status showed
v?andHealth: unknownwith no cause.worker-not-connectedcheck with the same fix.iii-on-path-not-local-binnow says which iii is used and what to run.Includes
docs:syncoutput in the same commit.Found through docs-assistant questions from users.
Test notes: targeted tests pass. Full-suite failures seen locally (fs-watcher, observation-source, graph timeouts) also fail on a clean origin/main checkout under load.
Summary by CodeRabbit