Repository navigation
fix(insights): retain only requested results while paging - #1783
zack-dev-cm wants to merge 1 commit into
Conversation
Signed-off-by: zack-dev-cm <112114097+zack-dev-cm@users.noreply.github.com>
|
@zack-dev-cm is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Merged as part of #1811, which kept your commits and added review fixes on top (details in its description). Thanks for the contribution. |
Listing a small number of historical insights currently keeps the entire collection in memory before filtering and sorting. Stream the existing pages into a sorted window capped at the requested limit, preserving complete records, filtering, confidence order and backend-specific ties. The Redis ordering key and comparator are shared with the existing KV ordering helper.
Related to #1548's listing path. All keys are still scanned; the list-only compatibility fallback still materializes its supplied list.
Validation:
Hosted CI verified at 19:00 UTC on 13 November 2026, on 05fcfdd (run 43487411593): all four Ubuntu Node 20/22/24/26 jobs pass the full 4,992-case suite, all 54 new checks and 144 affected checks, with both workflow build invocations. Node 20 reports 4,983 passed and 9 existing skips; Node 22/24/26 each report 4,985 passed and 7 skips. All 38 mesh checks pass in each job. macOS remains unvalidated in this run; a passing eight-job matrix is not established.
Summary by CodeRabbit