Repository navigation
fix: index flow-compressed memories and fold in five contributor fixes - #1811
Merged
Merged
Conversation
Signed-off-by: zack-dev-cm <112114097+zack-dev-cm@users.noreply.github.com>
Signed-off-by: zack-dev-cm <112114097+zack-dev-cm@users.noreply.github.com>
Signed-off-by: zack-dev-cm <112114097+zack-dev-cm@users.noreply.github.com>
Signed-off-by: zack-dev-cm <112114097+zack-dev-cm@users.noreply.github.com>
Signed-off-by: zack-dev-cm <112114097+zack-dev-cm@users.noreply.github.com>
Signed-off-by: zack-dev-cm <112114097+zack-dev-cm@users.noreply.github.com>
Signed-off-by: zack-dev-cm <112114097+zack-dev-cm@users.noreply.github.com>
- consolidation status: count summaries through StateKV.count instead of a copy of it. - audit listeners: addAuditListener returns its unsubscribe function, entries are frozen copies of the caller's targetIds and details so one listener cannot change what another sees, and listener failures are logged instead of dropped. Removed the internal-only doc. - hooks typecheck: run once in CI (ubuntu, Node 22) instead of in all eight matrix cells. Dropped the tsx source-hook spawn tests: the packaged hooks are already tested, and the HTTPS refusal is covered in directory-review-privacy.test.ts. - Replaced the oversized tests and fixtures for the summary count, durable replay lookup, insight paging and audit listeners with focused cases. Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
mem::flow-compress and mem::auto-page wrote memories to KV without indexing them, so search could not find them until a restart rebuilt BM25. Both now go through indexMemory, the funnel consolidate already uses. flow-compress also: - returns success:false and stores nothing when the reply has no summary sections, instead of saving an empty or raw-text memory; - supersedes its earlier memory for the same action set under the mem:remember lock, instead of adding a duplicate; - takes agentId from the caller (falling back to AGENT_ID) and trims project the way mem::remember does; - stamps project only when every compressed action belongs to it; - validates runId and actionIds, and the REST route forwards only runId, actionIds, project and agentId; - accepts summary tags that carry attributes. auto-page titles use the surrogate-safe title helper. The packaged graph gate ignores in-flight .bin.tmp files when listing graph files, so an atomic rename between readdir and stat no longer fails the gate. Co-authored-by: dimitri <dimitri.chrysafis@gmail.com> Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 18, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combines five contributor PRs with the reworked fix for flow-compress indexing (#1709). The contributors' commits are merged in unchanged, so their authorship is kept. The commits after the merges tighten each change and replace the oversized tests.
StateKV.count; test cut to 2 casesmem::insight-listkeeps only the toplimitresults while pagingaddAuditListenerreturns its unsubscribe; entries are frozen copies; listener failures are logged; internal doc removedsrc/hooksin CI.bin.tmprace fix keptMemory write path
mem::flow-compressandmem::auto-pagewrote memories to KV without indexing them. Both now callindexMemory, the same function consolidate uses. A full sweep of writes toKV.memoriesfound no other write path that skips the index.flow-compress also changes behavior:
success:falseand stores nothing. It does not store the raw model text or a placeholder.parentId), under themem:rememberlock. If marking the old memory fails, the new write is rolled back.agentIdcomes from the caller, falling back toAGENT_ID.projectis trimmed, and is stamped only when every compressed action belongs to it.runIdandactionIdsare type-checked. The REST route forwards onlyrunId,actionIds,projectandagentId.Not included from #1709: parallel candidate reads in
graph-retrieval.ts. That change touches the hot search path and needs its own PR with latency numbers.Testing
npx vitest run: 5,078 passed, 24 skipped.test/integration.test.tsfails here because no server runs on :3111; it needs a live daemon.npm run build,npm run typecheck:hooksandnpm run docs:checkpass.tsc --noEmitshows the same 28 existing errors as main.Merge with a merge commit, not a squash, so the contributor PRs show as merged.