Detect actual span for getting unexpected token from parsing macros#112518
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 27, 2023
Merged
Detect actual span for getting unexpected token from parsing macros#112518bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
Member
fn main() {
println!("{}", x-);
}errors with error: expected expression, found end of macro arguments
--> src/main.rs:2:22
|
2 | println!("{}", x-); //~ ERROR unexpected token: `)`
| ^ expected expressionwhich looks very nice. I would prefer it if the error here hooked into the same logic instead of trying to duplicate it |
Member
Author
|
davidtwco
approved these changes
Jun 27, 2023
Member
|
@bors r+ |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 27, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112518 (Detect actual span for getting unexpected token from parsing macros) - rust-lang#112978 (Add suggestion for bad block fragment error) - rust-lang#113068 (bootstrap: rename 'user' profile to 'dist') - rust-lang#113079 (Use `CoverageKind::as_operand_id` instead of manually reimplementing it) - rust-lang#113089 (Export AnalysisResults trait in rustc_mir_dataflow) - rust-lang#113093 (`thir`: Add `Become` expression kind) - rust-lang#113096 (Remove unused struct and tweak format macro uses) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112458