bootstrap: rename 'user' profile to 'dist'#113068
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 27, 2023
Merged
Conversation
rustbot
added
S-waiting-on-review
jyn514
reviewed
Jun 26, 2023
jyn514
added
S-waiting-on-author
rust-cloud-vms
bot
force-pushed
the
bootstrap-user-to-dist
branch
from
4d74d73 to
c195899
Compare
jyn514
approved these changes
Jun 26, 2023
Member
jyn514
left a comment
jyn514
left a comment
There was a problem hiding this comment.
thanks, this looks good! r=me with or without the nit fixed :)
rust-cloud-vms
bot
force-pushed
the
bootstrap-user-to-dist
branch
from
c195899 to
85c4ea0
Compare
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 27, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112518 (Detect actual span for getting unexpected token from parsing macros) - rust-lang#112978 (Add suggestion for bad block fragment error) - rust-lang#113068 (bootstrap: rename 'user' profile to 'dist') - rust-lang#113079 (Use `CoverageKind::as_operand_id` instead of manually reimplementing it) - rust-lang#113089 (Export AnalysisResults trait in rustc_mir_dataflow) - rust-lang#113093 (`thir`: Add `Become` expression kind) - rust-lang#113096 (Remove unused struct and tweak format macro uses) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112074
Unfortunately a big chunk of the diff is adding
PartialEq/Eq/Debugimpls so we canassert_eqbut I think better to have them in the long run.For back compat, ensure
"maintainer","user"and"dist"are all parsed asProfile::Dist.r? @jyn514
cc @AnakinSkywalkeer who worked on the previous attempt at this