Skip to content

std: use OnceLock for Xous environment variables#152535

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
joboet:xous_env_once_lock
Mar 9, 2026
Merged

std: use OnceLock for Xous environment variables#152535
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
joboet:xous_env_once_lock

Conversation

@joboet
Copy link
Member

@joboet joboet commented Feb 12, 2026

There's no need for exposed-provenance-shenanigans here...

CC @xobs

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 12, 2026
@joboet joboet marked this pull request as ready for review February 12, 2026 13:49
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2026

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from ChrisDenton, Mark-Simulacrum

@xobs
Copy link
Contributor

xobs commented Feb 13, 2026

This seems good to me. I believe the pointer shenanigans were from before we started collecting the arguments in an iterator, so it's good to get rid of it since it's not required.

@joboet
Copy link
Member Author

joboet commented Mar 2, 2026

@rustbot reroll

@rust-bors

This comment has been minimized.

@joboet joboet force-pushed the xous_env_once_lock branch from f9a1b3b to 6f980d4 Compare March 5, 2026 18:59
@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Mark-Simulacrum
Copy link
Member

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 8, 2026

📌 Commit 6f980d4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2026
rust-bors bot pushed a commit that referenced this pull request Mar 9, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #152535 (std: use `OnceLock` for Xous environment variables)
 - #152646 (Update `UnsafeUnpin` impls involving extern types.)
 - #153559 (Inline and simplify some code for saving incremental data to disk)
 - #151900 (num: Separate public API from internal implementations)
 - #153520 (.mailmap: fix broken line with multiple emails)
 - #153573 (rustdoc-json: fix incorrect documentation for VariantKind::Struct)

Failed merges:

 - #153509 (Cleanup unused diagnostic emission methods - part 2)
@rust-bors rust-bors bot merged commit 1ef29e7 into rust-lang:main Mar 9, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 9, 2026
rust-timer added a commit that referenced this pull request Mar 9, 2026
Rollup merge of #152535 - joboet:xous_env_once_lock, r=Mark-Simulacrum

std: use `OnceLock` for Xous environment variables

There's no need for exposed-provenance-shenanigans here...

CC @xobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants