Cleanup unused diagnostic emission methods - part 2#153509
Merged
rust-bors[bot] merged 8 commits intorust-lang:mainfrom Mar 9, 2026
Merged
Cleanup unused diagnostic emission methods - part 2#153509rust-bors[bot] merged 8 commits intorust-lang:mainfrom
rust-bors[bot] merged 8 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in match checking cc @Nadrieril Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the CTFE / Miri interpreter |
rustbot
added
the
S-waiting-on-review
rustbot
added
T-compiler
3 tasks
RalfJung
reviewed
Mar 6, 2026
JonathanBrouwer
requested changes
Mar 7, 2026
rustbot
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
migrate-diag2
branch
from
c5782b8 to
c7d83eb
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
commented
Mar 8, 2026
GuillaumeGomez
force-pushed
the
migrate-diag2
branch
from
c7d83eb to
fb80ceb
Compare
Member
Author
|
Introduced |
JonathanBrouwer
approved these changes
Mar 8, 2026
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
…uwer Rollup of 6 pull requests Successful merges: - #152535 (std: use `OnceLock` for Xous environment variables) - #152646 (Update `UnsafeUnpin` impls involving extern types.) - #153559 (Inline and simplify some code for saving incremental data to disk) - #151900 (num: Separate public API from internal implementations) - #153520 (.mailmap: fix broken line with multiple emails) - #153573 (rustdoc-json: fix incorrect documentation for VariantKind::Struct) Failed merges: - #153509 (Cleanup unused diagnostic emission methods - part 2)
rust-bors
bot
added
the
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
removed
the
S-waiting-on-bors
GuillaumeGomez
force-pushed
the
migrate-diag2
branch
from
4f397b6 to
dbbf3ea
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
…c_middle/src/mir/interpret/queries.rs`
GuillaumeGomez
force-pushed
the
migrate-diag2
branch
from
dbbf3ea to
d31a17f
Compare
Member
Author
|
@bors r=JonathanBrouwer rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152847 (Test for armv7 `get_unchecked(...)` inlining) - #153290 (tests: codegen-llvm: iter-repeat-n-trivial-drop: Allow non-zero lower bound to __rust_alloc size) - #153413 (std: organise `sys::pal::os`) - #139692 (Rustfmt now support use closures) - #152800 (Adds recursion limit into FindParamInClause) - #153244 (tools: remote-test-server: Add UEFI run support) - #153305 (Adapt codegen test to accept operand bundles) - #153340 (tweak r-a default settings) - #153509 (Cleanup unused diagnostic emission methods - part 2) - #153527 (Fix LegacyKeyValueFormat report from docker build: ohos) - #153594 (Move some ui tests)
rust-timer
added a commit
that referenced
this pull request
Mar 9, 2026
Rollup merge of #153509 - GuillaumeGomez:migrate-diag2, r=JonathanBrouwer Cleanup unused diagnostic emission methods - part 2 Part of #153099. r? @JonathanBrouwer
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 9, 2026
…n_with_style, r=JonathanBrouwer Add missing `Diag::with_span_suggestion_with_style` method Uncovered while working on rust-lang#153509. r? @JonathanBrouwer
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 9, 2026
…n_with_style, r=JonathanBrouwer Add missing `Diag::with_span_suggestion_with_style` method Uncovered while working on rust-lang#153509. r? @JonathanBrouwer
rust-timer
added a commit
that referenced
this pull request
Mar 10, 2026
Rollup merge of #153609 - GuillaumeGomez:with_span_suggestion_with_style, r=JonathanBrouwer Add missing `Diag::with_span_suggestion_with_style` method Uncovered while working on #153509. r? @JonathanBrouwer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #153099.
r? @JonathanBrouwer