Repository navigation
Mark the compile unit for -Zdebuginfo-for-profiling - #165490
Merged
rust-bors[bot] merged 1 commit intoNov 10, 2026
Merged
Conversation
With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.
Collaborator
|
Some changes occurred in compiler/rustc_codegen_llvm/src/debuginfo cc @Walnut356 |
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @cuviper (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 9, 2026
…ompile-unit, r=dtolnay Mark the compile unit for `-Zdebuginfo-for-profiling` With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 10, 2026
…ompile-unit, r=dtolnay Mark the compile unit for `-Zdebuginfo-for-profiling` With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 10, 2026
…ompile-unit, r=dtolnay Mark the compile unit for `-Zdebuginfo-for-profiling` With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 10, 2026
…ompile-unit, r=dtolnay Mark the compile unit for `-Zdebuginfo-for-profiling` With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
…uwer Rollup of 16 pull requests Successful merges: - #165575 (Upgrade bundled musl to 1.2.6) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims) - #165458 (fix incorrect byte count suffix on MSVC) - #165487 (Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164218 (Tweak private re-export errors to point at correct span and have more context) - #165709 (remove 'x miri' smoke test from PR CI)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 10, 2026
…ompile-unit, r=dtolnay Mark the compile unit for `-Zdebuginfo-for-profiling` With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
…uwer Rollup of 16 pull requests Successful merges: - #165575 (Upgrade bundled musl to 1.2.6) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims) - #165458 (fix incorrect byte count suffix on MSVC) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #164218 (Tweak private re-export errors to point at correct span and have more context) - #165709 (remove 'x miri' smoke test from PR CI)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 10, 2026
…ompile-unit, r=dtolnay Mark the compile unit for `-Zdebuginfo-for-profiling` With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 10, 2026
…ompile-unit, r=dtolnay Mark the compile unit for `-Zdebuginfo-for-profiling` With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.
This was referenced Nov 10, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
…uwer Rollup of 24 pull requests Successful merges: - #165709 (remove 'x miri' smoke test from PR CI) - #164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - #165569 (`Move` trait feature gate) - #165575 (Upgrade bundled musl to 1.2.6) - #163241 (Add enclosing item context when pointing at `FnMut` bound) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165047 (Change the span building of paths from first-to-last to chained) - #165458 (fix incorrect byte count suffix on MSVC) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #165753 (avoid Terminator:None in MIR inliner) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165562 (stop using gce in a test) - #165681 (Add safety requirements for Pattern and Searcher) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) - #165739 (remove NOP File::flush from fs tests) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #164218 (Tweak private re-export errors to point at correct span and have more context)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
…uwer Rollup of 24 pull requests Successful merges: - #165709 (remove 'x miri' smoke test from PR CI) - #164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - #165569 (`Move` trait feature gate) - #165575 (Upgrade bundled musl to 1.2.6) - #163241 (Add enclosing item context when pointing at `FnMut` bound) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165047 (Change the span building of paths from first-to-last to chained) - #165458 (fix incorrect byte count suffix on MSVC) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #165753 (avoid Terminator:None in MIR inliner) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165562 (stop using gce in a test) - #165681 (Add safety requirements for Pattern and Searcher) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) - #165739 (remove NOP File::flush from fs tests) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #164218 (Tweak private re-export errors to point at correct span and have more context)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
Rollup merge of #165490 - apolloww:debuginfo-for-profiling-compile-unit, r=dtolnay Mark the compile unit for `-Zdebuginfo-for-profiling` With `-Zdebuginfo-for-profiling`, set `debugInfoForProfiling` on the `DICompileUnit`, as Clang does for `-fdebug-info-for-profiling` (`CGDebugInfo.cpp`). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Nov 11, 2026
…uwer Rollup of 24 pull requests Successful merges: - rust-lang/rust#165709 (remove 'x miri' smoke test from PR CI) - rust-lang/rust#164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - rust-lang/rust#165569 (`Move` trait feature gate) - rust-lang/rust#165575 (Upgrade bundled musl to 1.2.6) - rust-lang/rust#163241 (Add enclosing item context when pointing at `FnMut` bound) - rust-lang/rust#163992 (add `core::arch::{x86, x86_64}::x87_f80`) - rust-lang/rust#165047 (Change the span building of paths from first-to-last to chained) - rust-lang/rust#165458 (fix incorrect byte count suffix on MSVC) - rust-lang/rust#165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - rust-lang/rust#165586 (Remove `backend_optimization_level`.) - rust-lang/rust#165646 (fix NumScalableVectors::from_field_count) - rust-lang/rust#165655 (Unignore passing GCC backend tests) - rust-lang/rust#165740 (miri subtree update) - rust-lang/rust#165753 (avoid Terminator:None in MIR inliner) - rust-lang/rust#153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - rust-lang/rust#164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - rust-lang/rust#165562 (stop using gce in a test) - rust-lang/rust#165681 (Add safety requirements for Pattern and Searcher) - rust-lang/rust#165682 (interpret: ensure newly created unions have uninit in their padding) - rust-lang/rust#165693 (Move `check_attr` to attribute parsing) - rust-lang/rust#165715 (windows: check for null before wide encoding) - rust-lang/rust#165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - rust-lang/rust#165733 (docs(num): remove needless whitespaces) - rust-lang/rust#165739 (remove NOP File::flush from fs tests) Failed merges: - rust-lang/rust#165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - rust-lang/rust#164218 (Tweak private re-export errors to point at correct span and have more context)
RalfJung
pushed a commit
to mehmettoplu-rs/miri
that referenced
this pull request
Nov 11, 2026
…uwer Rollup of 24 pull requests Successful merges: - rust-lang/rust#165709 (remove 'x miri' smoke test from PR CI) - rust-lang/rust#164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - rust-lang/rust#165569 (`Move` trait feature gate) - rust-lang/rust#165575 (Upgrade bundled musl to 1.2.6) - rust-lang/rust#163241 (Add enclosing item context when pointing at `FnMut` bound) - rust-lang/rust#163992 (add `core::arch::{x86, x86_64}::x87_f80`) - rust-lang/rust#165047 (Change the span building of paths from first-to-last to chained) - rust-lang/rust#165458 (fix incorrect byte count suffix on MSVC) - rust-lang/rust#165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - rust-lang/rust#165586 (Remove `backend_optimization_level`.) - rust-lang/rust#165646 (fix NumScalableVectors::from_field_count) - rust-lang/rust#165655 (Unignore passing GCC backend tests) - rust-lang/rust#165740 (miri subtree update) - rust-lang/rust#165753 (avoid Terminator:None in MIR inliner) - rust-lang/rust#153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - rust-lang/rust#164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - rust-lang/rust#165562 (stop using gce in a test) - rust-lang/rust#165681 (Add safety requirements for Pattern and Searcher) - rust-lang/rust#165682 (interpret: ensure newly created unions have uninit in their padding) - rust-lang/rust#165693 (Move `check_attr` to attribute parsing) - rust-lang/rust#165715 (windows: check for null before wide encoding) - rust-lang/rust#165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - rust-lang/rust#165733 (docs(num): remove needless whitespaces) - rust-lang/rust#165739 (remove NOP File::flush from fs tests) Failed merges: - rust-lang/rust#165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - rust-lang/rust#164218 (Tweak private re-export errors to point at correct span and have more context)
github-actions Bot
pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Nov 12, 2026
…uwer Rollup of 24 pull requests Successful merges: - rust-lang/rust#165709 (remove 'x miri' smoke test from PR CI) - rust-lang/rust#164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - rust-lang/rust#165569 (`Move` trait feature gate) - rust-lang/rust#165575 (Upgrade bundled musl to 1.2.6) - rust-lang/rust#163241 (Add enclosing item context when pointing at `FnMut` bound) - rust-lang/rust#163992 (add `core::arch::{x86, x86_64}::x87_f80`) - rust-lang/rust#165047 (Change the span building of paths from first-to-last to chained) - rust-lang/rust#165458 (fix incorrect byte count suffix on MSVC) - rust-lang/rust#165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - rust-lang/rust#165586 (Remove `backend_optimization_level`.) - rust-lang/rust#165646 (fix NumScalableVectors::from_field_count) - rust-lang/rust#165655 (Unignore passing GCC backend tests) - rust-lang/rust#165740 (miri subtree update) - rust-lang/rust#165753 (avoid Terminator:None in MIR inliner) - rust-lang/rust#153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - rust-lang/rust#164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - rust-lang/rust#165562 (stop using gce in a test) - rust-lang/rust#165681 (Add safety requirements for Pattern and Searcher) - rust-lang/rust#165682 (interpret: ensure newly created unions have uninit in their padding) - rust-lang/rust#165693 (Move `check_attr` to attribute parsing) - rust-lang/rust#165715 (windows: check for null before wide encoding) - rust-lang/rust#165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - rust-lang/rust#165733 (docs(num): remove needless whitespaces) - rust-lang/rust#165739 (remove NOP File::flush from fs tests) Failed merges: - rust-lang/rust#165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - rust-lang/rust#164218 (Tweak private re-export errors to point at correct span and have more context)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-Zdebuginfo-for-profiling, setdebugInfoForProfilingon theDICompileUnit, as Clang does for-fdebug-info-for-profiling(CGDebugInfo.cpp). Before this change, the flag only added the discriminators pass, and the compile unit flag was always false.