Repository navigation
remove 'x miri' smoke test from PR CI - #165709
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
We could honestly consider removing this smoke test entirely, I don't know if it ever triggered -- not sure if it's worth running that for each PR. |
|
Looking at the times, it seems like the smoke tests overall take 3-4 minutes and almost none of that is spent on doctests. I'd propose we remove them entirely then. It does not seem very likely that most PRs break this. |
|
r? kobzol @bors r+ rollup |
…uwer Rollup of 16 pull requests Successful merges: - #165575 (Upgrade bundled musl to 1.2.6) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims) - #165458 (fix incorrect byte count suffix on MSVC) - #165487 (Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164218 (Tweak private re-export errors to point at correct span and have more context) - #165709 (remove 'x miri' smoke test from PR CI)
…uwer Rollup of 16 pull requests Successful merges: - #165575 (Upgrade bundled musl to 1.2.6) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims) - #165458 (fix incorrect byte count suffix on MSVC) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #164218 (Tweak private re-export errors to point at correct span and have more context) - #165709 (remove 'x miri' smoke test from PR CI)
|
Warning If you are changing how CI LLVM is built or linked, make sure to bump cc @jieyouxu |
|
This pull request was unapproved. |
|
@bors rollup p=1 |
|
@bors r=RalfJung force |
|
@bors p=1 |
|
It seems to ignore the p=1 when it is in "waiting for CI" state? |
|
The problem is that the |
|
bors has "commands"? I thought it's just a bunch of flags that I can pass in ~any order...^^ |
…uwer Rollup of 24 pull requests Successful merges: - #165709 (remove 'x miri' smoke test from PR CI) - #164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - #165569 (`Move` trait feature gate) - #165575 (Upgrade bundled musl to 1.2.6) - #163241 (Add enclosing item context when pointing at `FnMut` bound) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165047 (Change the span building of paths from first-to-last to chained) - #165458 (fix incorrect byte count suffix on MSVC) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #165753 (avoid Terminator:None in MIR inliner) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165562 (stop using gce in a test) - #165681 (Add safety requirements for Pattern and Searcher) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) - #165739 (remove NOP File::flush from fs tests) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #164218 (Tweak private re-export errors to point at correct span and have more context)
|
I don't know what you're talking about, the command set is well documented :) 😆 https://bors.rust-lang.org/help |
|
⌛ Testing commit 65f2c77 with merge 7fd1a43... Workflow: https://github.com/rust-lang/rust/actions/runs/42864465062 |
remove 'x miri' smoke test from PR CI This is often the slowest PR CI job, so it's worth speeding it up a little. I added it because `./x miri` uses some... interesting... hacks to get the test crates to compile. But this doesn't seem worth checking pre-bors, it is quite unlikely to break in most PRs. We do still [run](https://github.com/rust-lang/rust/blob/85110540b5163b34fd13daf633292383458169f9/src/bootstrap/mk/Makefile.in#L62-L91) these commands in bors CI. Cc @rust-lang/miri
|
@bors yield |
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #165760. |
…uwer Rollup of 24 pull requests Successful merges: - #165709 (remove 'x miri' smoke test from PR CI) - #164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - #165569 (`Move` trait feature gate) - #165575 (Upgrade bundled musl to 1.2.6) - #163241 (Add enclosing item context when pointing at `FnMut` bound) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165047 (Change the span building of paths from first-to-last to chained) - #165458 (fix incorrect byte count suffix on MSVC) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #165753 (avoid Terminator:None in MIR inliner) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165562 (stop using gce in a test) - #165681 (Add safety requirements for Pattern and Searcher) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) - #165739 (remove NOP File::flush from fs tests) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #164218 (Tweak private re-export errors to point at correct span and have more context)
Rollup merge of #165709 - RalfJung:check-miri, r=RalfJung remove 'x miri' smoke test from PR CI This is often the slowest PR CI job, so it's worth speeding it up a little. I added it because `./x miri` uses some... interesting... hacks to get the test crates to compile. But this doesn't seem worth checking pre-bors, it is quite unlikely to break in most PRs. We do still [run](https://github.com/rust-lang/rust/blob/85110540b5163b34fd13daf633292383458169f9/src/bootstrap/mk/Makefile.in#L62-L91) these commands in bors CI. Cc @rust-lang/miri
…uwer Rollup of 24 pull requests Successful merges: - rust-lang/rust#165709 (remove 'x miri' smoke test from PR CI) - rust-lang/rust#164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - rust-lang/rust#165569 (`Move` trait feature gate) - rust-lang/rust#165575 (Upgrade bundled musl to 1.2.6) - rust-lang/rust#163241 (Add enclosing item context when pointing at `FnMut` bound) - rust-lang/rust#163992 (add `core::arch::{x86, x86_64}::x87_f80`) - rust-lang/rust#165047 (Change the span building of paths from first-to-last to chained) - rust-lang/rust#165458 (fix incorrect byte count suffix on MSVC) - rust-lang/rust#165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - rust-lang/rust#165586 (Remove `backend_optimization_level`.) - rust-lang/rust#165646 (fix NumScalableVectors::from_field_count) - rust-lang/rust#165655 (Unignore passing GCC backend tests) - rust-lang/rust#165740 (miri subtree update) - rust-lang/rust#165753 (avoid Terminator:None in MIR inliner) - rust-lang/rust#153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - rust-lang/rust#164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - rust-lang/rust#165562 (stop using gce in a test) - rust-lang/rust#165681 (Add safety requirements for Pattern and Searcher) - rust-lang/rust#165682 (interpret: ensure newly created unions have uninit in their padding) - rust-lang/rust#165693 (Move `check_attr` to attribute parsing) - rust-lang/rust#165715 (windows: check for null before wide encoding) - rust-lang/rust#165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - rust-lang/rust#165733 (docs(num): remove needless whitespaces) - rust-lang/rust#165739 (remove NOP File::flush from fs tests) Failed merges: - rust-lang/rust#165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - rust-lang/rust#164218 (Tweak private re-export errors to point at correct span and have more context)
…uwer Rollup of 24 pull requests Successful merges: - rust-lang/rust#165709 (remove 'x miri' smoke test from PR CI) - rust-lang/rust#164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - rust-lang/rust#165569 (`Move` trait feature gate) - rust-lang/rust#165575 (Upgrade bundled musl to 1.2.6) - rust-lang/rust#163241 (Add enclosing item context when pointing at `FnMut` bound) - rust-lang/rust#163992 (add `core::arch::{x86, x86_64}::x87_f80`) - rust-lang/rust#165047 (Change the span building of paths from first-to-last to chained) - rust-lang/rust#165458 (fix incorrect byte count suffix on MSVC) - rust-lang/rust#165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - rust-lang/rust#165586 (Remove `backend_optimization_level`.) - rust-lang/rust#165646 (fix NumScalableVectors::from_field_count) - rust-lang/rust#165655 (Unignore passing GCC backend tests) - rust-lang/rust#165740 (miri subtree update) - rust-lang/rust#165753 (avoid Terminator:None in MIR inliner) - rust-lang/rust#153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - rust-lang/rust#164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - rust-lang/rust#165562 (stop using gce in a test) - rust-lang/rust#165681 (Add safety requirements for Pattern and Searcher) - rust-lang/rust#165682 (interpret: ensure newly created unions have uninit in their padding) - rust-lang/rust#165693 (Move `check_attr` to attribute parsing) - rust-lang/rust#165715 (windows: check for null before wide encoding) - rust-lang/rust#165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - rust-lang/rust#165733 (docs(num): remove needless whitespaces) - rust-lang/rust#165739 (remove NOP File::flush from fs tests) Failed merges: - rust-lang/rust#165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - rust-lang/rust#164218 (Tweak private re-export errors to point at correct span and have more context)
…uwer Rollup of 24 pull requests Successful merges: - rust-lang/rust#165709 (remove 'x miri' smoke test from PR CI) - rust-lang/rust#164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - rust-lang/rust#165569 (`Move` trait feature gate) - rust-lang/rust#165575 (Upgrade bundled musl to 1.2.6) - rust-lang/rust#163241 (Add enclosing item context when pointing at `FnMut` bound) - rust-lang/rust#163992 (add `core::arch::{x86, x86_64}::x87_f80`) - rust-lang/rust#165047 (Change the span building of paths from first-to-last to chained) - rust-lang/rust#165458 (fix incorrect byte count suffix on MSVC) - rust-lang/rust#165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - rust-lang/rust#165586 (Remove `backend_optimization_level`.) - rust-lang/rust#165646 (fix NumScalableVectors::from_field_count) - rust-lang/rust#165655 (Unignore passing GCC backend tests) - rust-lang/rust#165740 (miri subtree update) - rust-lang/rust#165753 (avoid Terminator:None in MIR inliner) - rust-lang/rust#153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - rust-lang/rust#164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - rust-lang/rust#165562 (stop using gce in a test) - rust-lang/rust#165681 (Add safety requirements for Pattern and Searcher) - rust-lang/rust#165682 (interpret: ensure newly created unions have uninit in their padding) - rust-lang/rust#165693 (Move `check_attr` to attribute parsing) - rust-lang/rust#165715 (windows: check for null before wide encoding) - rust-lang/rust#165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - rust-lang/rust#165733 (docs(num): remove needless whitespaces) - rust-lang/rust#165739 (remove NOP File::flush from fs tests) Failed merges: - rust-lang/rust#165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - rust-lang/rust#164218 (Tweak private re-export errors to point at correct span and have more context)
View all comments
This is often the slowest PR CI job, so it's worth speeding it up a little. I added it because
./x miriuses some... interesting... hacks to get the test crates to compile. But this doesn't seem worth checking pre-bors, it is quite unlikely to break in most PRs.We do still run these commands in bors CI.
Cc @rust-lang/miri