Repository navigation
DFV: Reject #[non_exhaustive] on enum variants with default field values - #165505
Merged
rust-bors[bot] merged 1 commit intoNov 7, 2026
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
estebank
approved these changes
Nov 5, 2026
Comment on lines
1
to
+8
| error: default variant must be exhaustive | ||
| --> $DIR/default-field-values-non_exhaustive.rs:13:5 | ||
| --> $DIR/default-field-values-non_exhaustive.rs:23:5 | ||
| | | ||
| LL | #[non_exhaustive] | ||
| | ----------------- declared `#[non_exhaustive]` here | ||
| LL | #[default] | ||
| LL | Baz { | ||
| | ^^^ | ||
| ... | ||
| LL | Variant { | ||
| | ^^^^^^^ |
Contributor
There was a problem hiding this comment.
Pre-existing: this error should at the very least provide a span context to #[default], if not a full blown span label saying "Variant made default here"
fmease
force-pushed
the
dfv-rej-nonex-struct-like-variant
branch
from
November 5, 2026 16:52
76f0b0e to
d40c05a
Compare
Member
Author
|
(forced-pushed a stylistic code change)
We have tentative approvals now, approving tentatively... @bors r=estebank rollup |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 5, 2026
…ariant, r=estebank DFV: Reject `#[non_exhaustive]` on enum variants with default field values Fixes rust-lang#165143. Part of rust-lang#132162. r? estebank or compiler <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
…uwer Rollup of 6 pull requests Successful merges: - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion) - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`) - #165503 (update Enzyme submodule) - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values) - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types) - #165519 (Update books)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
…uwer Rollup of 6 pull requests Successful merges: - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion) - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`) - #165503 (update Enzyme submodule) - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values) - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types) - #165519 (Update books)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 6, 2026
…ariant, r=estebank DFV: Reject `#[non_exhaustive]` on enum variants with default field values Fixes rust-lang#165143. Part of rust-lang#132162. r? estebank or compiler <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 6, 2026
…ariant, r=estebank DFV: Reject `#[non_exhaustive]` on enum variants with default field values Fixes rust-lang#165143. Part of rust-lang#132162. r? estebank or compiler <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
…uwer Rollup of 19 pull requests Successful merges: - #164784 (Introduce OptimizationObjective and fix the entry shim's size attributes) - #165037 (Drop array elements in order after a partial move) - #165078 (Use the `2.38` binutils version in CI) - #159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name]) - #163284 (feat(Reborrow): Allow multiple lifetimes) - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion) - #165194 (name elided lifetimes in `use<...>` suggestion when `impl Trait` params are present) - #165222 (Anonymize inner binders when checking refining) - #165335 (Fallible type ops) - #165388 (Accept variadic SysV64, Win64, and Aapcs FnAbis in rustc_public) - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`) - #165494 (fix Miri ICE on exit with () return type) - #165503 (update Enzyme submodule) - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values) - #165512 (Fix warnings for the L4Re targets) - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types) - #165518 (style-guide: Remove ABI explicitness prescription for extern items) - #165519 (Update books) - #165534 (rename MIR_borrow_checking timing scope to less confusing name)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 7, 2026
Rollup of 15 pull requests Successful merges: - #165037 (Drop array elements in order after a partial move) - #165550 (Make `Literal::cstr_value` return a `CString`) - #159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name]) - #163284 (feat(Reborrow): Allow multiple lifetimes) - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion) - #165194 (name elided lifetimes in `use<...>` suggestion when `impl Trait` params are present) - #165222 (Anonymize inner binders when checking refining) - #165335 (Fallible type ops) - #165388 (Accept variadic SysV64, Win64, and Aapcs FnAbis in rustc_public) - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`) - #165494 (fix Miri ICE on exit with () return type) - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values) - #165512 (Fix warnings for the L4Re targets) - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types) - #165518 (style-guide: Remove ABI explicitness prescription for extern items)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 7, 2026
Rollup merge of #165505 - fmease:dfv-rej-nonex-struct-like-variant, r=estebank DFV: Reject `#[non_exhaustive]` on enum variants with default field values Fixes #165143. Part of #132162. r? estebank or compiler <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
RalfJung
pushed a commit
to JoJoDeveloping/miri
that referenced
this pull request
Nov 8, 2026
Rollup of 15 pull requests Successful merges: - rust-lang/rust#165037 (Drop array elements in order after a partial move) - rust-lang/rust#165550 (Make `Literal::cstr_value` return a `CString`) - rust-lang/rust#159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name]) - rust-lang/rust#163284 (feat(Reborrow): Allow multiple lifetimes) - rust-lang/rust#164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion) - rust-lang/rust#165194 (name elided lifetimes in `use<...>` suggestion when `impl Trait` params are present) - rust-lang/rust#165222 (Anonymize inner binders when checking refining) - rust-lang/rust#165335 (Fallible type ops) - rust-lang/rust#165388 (Accept variadic SysV64, Win64, and Aapcs FnAbis in rustc_public) - rust-lang/rust#165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`) - rust-lang/rust#165494 (fix Miri ICE on exit with () return type) - rust-lang/rust#165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values) - rust-lang/rust#165512 (Fix warnings for the L4Re targets) - rust-lang/rust#165514 (Remove unused `WhereEqPredicate` and `ScopeId` types) - rust-lang/rust#165518 (style-guide: Remove ABI explicitness prescription for extern items)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #165143.
Part of #132162.
r? estebank or compiler
(No LLM was or will be used by me during the entire creation process of this PR)