Skip to content

DFV: Reject #[non_exhaustive] on enum variants with default field values - #165505

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
fmease:dfv-rej-nonex-struct-like-variant
Nov 7, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
fmease:dfv-rej-nonex-struct-like-variant

Conversation

@fmease

@fmease fmease commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Fixes #165143.
Part of #132162.

r? estebank or compiler

(No LLM was or will be used by me during the entire creation process of this PR)

@fmease fmease added the F-default_field_values `#![feature(default_field_values)]` label Nov 5, 2026
@rustbot

rustbot commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 5, 2026

@estebank estebank left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once CI is green

View changes since this review

Comment on lines 1 to +8
error: default variant must be exhaustive
--> $DIR/default-field-values-non_exhaustive.rs:13:5
--> $DIR/default-field-values-non_exhaustive.rs:23:5
|
LL | #[non_exhaustive]
| ----------------- declared `#[non_exhaustive]` here
LL | #[default]
LL | Baz {
| ^^^
...
LL | Variant {
| ^^^^^^^

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-existing: this error should at the very least provide a span context to #[default], if not a full blown span label saying "Variant made default here"

@fmease
fmease force-pushed the dfv-rej-nonex-struct-like-variant branch from 76f0b0e to d40c05a Compare November 5, 2026 16:52
@fmease

fmease commented Nov 5, 2026 •

Copy link
Copy Markdown
Member Author

(forced-pushed a stylistic code change)

r=me once CI is green

We have tentative approvals now, approving tentatively...

@bors r=estebank rollup

@rust-bors

rust-bors Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d40c05a has been tentatively approved by estebank

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 5, 2026
…ariant, r=estebank

DFV: Reject `#[non_exhaustive]` on enum variants with default field values

Fixes rust-lang#165143.
Part of rust-lang#132162.

r? estebank or compiler

<sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
rust-bors Bot pushed a commit that referenced this pull request Nov 5, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion)
 - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`)
 - #165503 (update Enzyme submodule)
 - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values)
 - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types)
 - #165519 (Update books)
rust-bors Bot pushed a commit that referenced this pull request Nov 6, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion)
 - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`)
 - #165503 (update Enzyme submodule)
 - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values)
 - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types)
 - #165519 (Update books)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 6, 2026
…ariant, r=estebank

DFV: Reject `#[non_exhaustive]` on enum variants with default field values

Fixes rust-lang#165143.
Part of rust-lang#132162.

r? estebank or compiler

<sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 6, 2026
…ariant, r=estebank

DFV: Reject `#[non_exhaustive]` on enum variants with default field values

Fixes rust-lang#165143.
Part of rust-lang#132162.

r? estebank or compiler

<sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
rust-bors Bot pushed a commit that referenced this pull request Nov 6, 2026
…uwer

Rollup of 19 pull requests

Successful merges:

 - #164784 (Introduce OptimizationObjective and fix the entry shim's size attributes)
 - #165037 (Drop array elements in order after a partial move)
 - #165078 (Use the `2.38` binutils version in CI)
 - #159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name])
 - #163284 (feat(Reborrow): Allow multiple lifetimes)
 - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion)
 - #165194 (name elided lifetimes in `use<...>` suggestion when `impl Trait` params are present)
 - #165222 (Anonymize inner binders when checking refining)
 - #165335 (Fallible type ops)
 - #165388 (Accept variadic SysV64, Win64, and Aapcs FnAbis in rustc_public)
 - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`)
 - #165494 (fix Miri ICE on exit with () return type)
 - #165503 (update Enzyme submodule)
 - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values)
 - #165512 (Fix warnings for the L4Re targets)
 - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types)
 - #165518 (style-guide: Remove ABI explicitness prescription for extern items)
 - #165519 (Update books)
 - #165534 (rename MIR_borrow_checking timing scope to less confusing name)
rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
Rollup of 15 pull requests

Successful merges:

 - #165037 (Drop array elements in order after a partial move)
 - #165550 (Make `Literal::cstr_value` return a `CString`)
 - #159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name])
 - #163284 (feat(Reborrow): Allow multiple lifetimes)
 - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion)
 - #165194 (name elided lifetimes in `use<...>` suggestion when `impl Trait` params are present)
 - #165222 (Anonymize inner binders when checking refining)
 - #165335 (Fallible type ops)
 - #165388 (Accept variadic SysV64, Win64, and Aapcs FnAbis in rustc_public)
 - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`)
 - #165494 (fix Miri ICE on exit with () return type)
 - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values)
 - #165512 (Fix warnings for the L4Re targets)
 - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types)
 - #165518 (style-guide: Remove ABI explicitness prescription for extern items)
@rust-bors
rust-bors Bot merged commit 4cd5b62 into rust-lang:main Nov 7, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Nov 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
Rollup merge of #165505 - fmease:dfv-rej-nonex-struct-like-variant, r=estebank

DFV: Reject `#[non_exhaustive]` on enum variants with default field values

Fixes #165143.
Part of #132162.

r? estebank or compiler

<sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
@fmease
fmease deleted the dfv-rej-nonex-struct-like-variant branch November 7, 2026 10:54
RalfJung pushed a commit to JoJoDeveloping/miri that referenced this pull request Nov 8, 2026
Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#165037 (Drop array elements in order after a partial move)
 - rust-lang/rust#165550 (Make `Literal::cstr_value` return a `CString`)
 - rust-lang/rust#159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name])
 - rust-lang/rust#163284 (feat(Reborrow): Allow multiple lifetimes)
 - rust-lang/rust#164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion)
 - rust-lang/rust#165194 (name elided lifetimes in `use<...>` suggestion when `impl Trait` params are present)
 - rust-lang/rust#165222 (Anonymize inner binders when checking refining)
 - rust-lang/rust#165335 (Fallible type ops)
 - rust-lang/rust#165388 (Accept variadic SysV64, Win64, and Aapcs FnAbis in rustc_public)
 - rust-lang/rust#165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`)
 - rust-lang/rust#165494 (fix Miri ICE on exit with () return type)
 - rust-lang/rust#165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values)
 - rust-lang/rust#165512 (Fix warnings for the L4Re targets)
 - rust-lang/rust#165514 (Remove unused `WhereEqPredicate` and `ScopeId` types)
 - rust-lang/rust#165518 (style-guide: Remove ABI explicitness prescription for extern items)
@cuviper cuviper removed this from the 1.101.0 milestone Nov 9, 2026
@cuviper cuviper added this to the 1.102.0 milestone Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) F-default_field_values `#![feature(default_field_values)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

While we reject #[non_exhaustive] on structs with DFVs we don't do so for #[non_exhaustive] on enum variants with DFVs

4 participants