Skip to content

style-guide: Remove ABI explicitness prescription for extern items - #165518

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kolgrim33:style-guide-remove-abi-prescription-152760
Nov 7, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Kolgrim33:style-guide-remove-abi-prescription-152760

Conversation

@Kolgrim33

@Kolgrim33 Kolgrim33 commented Nov 5, 2026 •

Copy link
Copy Markdown

Per the Style Team FCP decision in #152760, remove the ## extern items prescription requiring an explicit ABI from the Style Guide. Formatters should preserve the ABI as written in the AST rather than inserting an explicit ABI when omitted, leaving missing-ABI diagnostics to language lints.

Fixes #152760

@rustbot label +I-style-nominated

Per the style team FCP in rust-lang#152760, remove the prescription requiring an explicit ABI on extern items so formatters preserve the ABI as written in the AST and defer missing-ABI diagnostics to language lints.
@rustbot

rustbot commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/doc/style-guide

cc @rust-lang/style

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-style Relevant to the style team, which will review and decide on the PR/issue. labels Nov 5, 2026
@rustbot

rustbot commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project has assigned @traviscross (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks.

Please see the contribution instructions and our LLM policy for more information.

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: style-team
  • style-team expanded to calebcartwright, joshtriplett, traviscross
  • Random selection from calebcartwright, traviscross

@rustbot rustbot added the I-style-nominated Nominated for discussion during a style team meeting. label Nov 5, 2026
@rustbot

rustbot commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtrees.

@joshtriplett

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit dc7eb41 has been approved by joshtriplett

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 6, 2026
…rescription-152760, r=joshtriplett

style-guide: Remove ABI explicitness prescription for extern items

Per the Style Team FCP decision in rust-lang#152760, remove the `## extern items` prescription requiring an explicit ABI from the Style Guide. Formatters should preserve the ABI as written in the AST rather than inserting an explicit ABI when omitted, leaving missing-ABI diagnostics to language lints.

Fixes rust-lang#152760

@rustbot label +I-style-nominated
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 6, 2026
…rescription-152760, r=joshtriplett

style-guide: Remove ABI explicitness prescription for extern items

Per the Style Team FCP decision in rust-lang#152760, remove the `## extern items` prescription requiring an explicit ABI from the Style Guide. Formatters should preserve the ABI as written in the AST rather than inserting an explicit ABI when omitted, leaving missing-ABI diagnostics to language lints.

Fixes rust-lang#152760

@rustbot label +I-style-nominated
rust-bors Bot pushed a commit that referenced this pull request Nov 6, 2026
…uwer

Rollup of 19 pull requests

Successful merges:

 - #164784 (Introduce OptimizationObjective and fix the entry shim's size attributes)
 - #165037 (Drop array elements in order after a partial move)
 - #165078 (Use the `2.38` binutils version in CI)
 - #159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name])
 - #163284 (feat(Reborrow): Allow multiple lifetimes)
 - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion)
 - #165194 (name elided lifetimes in `use<...>` suggestion when `impl Trait` params are present)
 - #165222 (Anonymize inner binders when checking refining)
 - #165335 (Fallible type ops)
 - #165388 (Accept variadic SysV64, Win64, and Aapcs FnAbis in rustc_public)
 - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`)
 - #165494 (fix Miri ICE on exit with () return type)
 - #165503 (update Enzyme submodule)
 - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values)
 - #165512 (Fix warnings for the L4Re targets)
 - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types)
 - #165518 (style-guide: Remove ABI explicitness prescription for extern items)
 - #165519 (Update books)
 - #165534 (rename MIR_borrow_checking timing scope to less confusing name)
rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
Rollup of 15 pull requests

Successful merges:

 - #165037 (Drop array elements in order after a partial move)
 - #165550 (Make `Literal::cstr_value` return a `CString`)
 - #159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name])
 - #163284 (feat(Reborrow): Allow multiple lifetimes)
 - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion)
 - #165194 (name elided lifetimes in `use<...>` suggestion when `impl Trait` params are present)
 - #165222 (Anonymize inner binders when checking refining)
 - #165335 (Fallible type ops)
 - #165388 (Accept variadic SysV64, Win64, and Aapcs FnAbis in rustc_public)
 - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`)
 - #165494 (fix Miri ICE on exit with () return type)
 - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values)
 - #165512 (Fix warnings for the L4Re targets)
 - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types)
 - #165518 (style-guide: Remove ABI explicitness prescription for extern items)
@rust-bors
rust-bors Bot merged commit 79620ea into rust-lang:main Nov 7, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Nov 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
Rollup merge of #165518 - Kolgrim33:style-guide-remove-abi-prescription-152760, r=joshtriplett

style-guide: Remove ABI explicitness prescription for extern items

Per the Style Team FCP decision in #152760, remove the `## extern items` prescription requiring an explicit ABI from the Style Guide. Formatters should preserve the ABI as written in the AST rather than inserting an explicit ABI when omitted, leaving missing-ABI diagnostics to language lints.

Fixes #152760

@rustbot label +I-style-nominated
RalfJung pushed a commit to JoJoDeveloping/miri that referenced this pull request Nov 8, 2026
Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#165037 (Drop array elements in order after a partial move)
 - rust-lang/rust#165550 (Make `Literal::cstr_value` return a `CString`)
 - rust-lang/rust#159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name])
 - rust-lang/rust#163284 (feat(Reborrow): Allow multiple lifetimes)
 - rust-lang/rust#164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion)
 - rust-lang/rust#165194 (name elided lifetimes in `use<...>` suggestion when `impl Trait` params are present)
 - rust-lang/rust#165222 (Anonymize inner binders when checking refining)
 - rust-lang/rust#165335 (Fallible type ops)
 - rust-lang/rust#165388 (Accept variadic SysV64, Win64, and Aapcs FnAbis in rustc_public)
 - rust-lang/rust#165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`)
 - rust-lang/rust#165494 (fix Miri ICE on exit with () return type)
 - rust-lang/rust#165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values)
 - rust-lang/rust#165512 (Fix warnings for the L4Re targets)
 - rust-lang/rust#165514 (Remove unused `WhereEqPredicate` and `ScopeId` types)
 - rust-lang/rust#165518 (style-guide: Remove ABI explicitness prescription for extern items)
@cuviper cuviper modified the milestones: 1.101.0, 1.102.0 Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I-style-nominated Nominated for discussion during a style team meeting. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-style Relevant to the style team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style Guide prescriptions on ABI explicitness

6 participants