Skip to content

Wrap proc-macro EscapeError enum into a struct - #165750

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:escape-error-struct
Nov 11, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:escape-error-struct

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

As discussed in #151973.

Part of #165750.

r? @programmerjake

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 10, 2026
@rustbot

rustbot commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

programmerjake is not on the review rotation at the moment.
They may take a while to respond.

@programmerjake programmerjake left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though there is an efficiency nit.

@bors delegate

View changes since this review

Comment thread library/proc_macro/src/lib.rs Outdated
#[unstable(feature = "proc_macro_value", issue = "136652")]
impl fmt::Display for EscapeError {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(f, "{}", self.kind)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
write!(f, "{}", self.kind)
fmt::Display::fmt(&self.kind, f)

@rust-bors

rust-bors Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

✌️ @GuillaumeGomez, you can now approve this pull request!

If @programmerjake told you to "r=me" after making some further change, then please make that change and post @bors r=programmerjake.

View changes since this delegation.

@GuillaumeGomez

Copy link
Copy Markdown
Member Author

@bors r=programmerjake

@rust-bors

rust-bors Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c22a287 has been approved by programmerjake

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 11, 2026
Rollup of 9 pull requests

Successful merges:

 - #165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims)
 - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test)
 - #165750 (Wrap proc-macro `EscapeError` enum into a struct)
 - #164218 (Tweak private re-export errors to point at correct span and have more context)
 - #165021 (In irrefutable patterns, the FieldPat is skipped, which means the name: field is not printed)
 - #165537 (Canonicalization cleanups)
 - #165772 (Remove unnecessary mut from HirIdValidator::check_nested_id)
 - #165779 (make improper_ctypes accept `x87_f80`)
 - #165780 (std: map more errno values to ErrorKind on Hermit)
@rust-bors
rust-bors Bot merged commit b220058 into rust-lang:main Nov 11, 2026
14 checks passed
rust-bors Bot pushed a commit that referenced this pull request Nov 11, 2026
Rollup merge of #165750 - GuillaumeGomez:escape-error-struct, r=programmerjake

Wrap proc-macro `EscapeError` enum into a struct

As discussed in #151973.

Part of #165750.

r? @programmerjake
@rustbot rustbot added this to the 1.102.0 milestone Nov 11, 2026
@GuillaumeGomez
GuillaumeGomez deleted the escape-error-struct branch November 11, 2026 11:50
mehmettoplu-rs pushed a commit to mehmettoplu-rs/miri that referenced this pull request Nov 13, 2026
…ammerjake

Wrap proc-macro `EscapeError` enum into a struct

As discussed in rust-lang/rust#151973.

Part of rust-lang/rust#165750.

r? @programmerjake
mehmettoplu-rs pushed a commit to mehmettoplu-rs/miri that referenced this pull request Nov 13, 2026
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims)
 - rust-lang/rust#165727 (Normalize "beta release channel" in `const-supertrait-unstable` test)
 - rust-lang/rust#165750 (Wrap proc-macro `EscapeError` enum into a struct)
 - rust-lang/rust#164218 (Tweak private re-export errors to point at correct span and have more context)
 - rust-lang/rust#165021 (In irrefutable patterns, the FieldPat is skipped, which means the name: field is not printed)
 - rust-lang/rust#165537 (Canonicalization cleanups)
 - rust-lang/rust#165772 (Remove unnecessary mut from HirIdValidator::check_nested_id)
 - rust-lang/rust#165779 (make improper_ctypes accept `x87_f80`)
 - rust-lang/rust#165780 (std: map more errno values to ErrorKind on Hermit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants