Repository navigation
Remove unnecessary mut from HirIdValidator::check_nested_id - #165772
Merged
rust-bors[bot] merged 1 commit intoNov 11, 2026
Merged
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @mu001999 (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
teor2345
approved these changes
Nov 10, 2026
JonathanBrouwer
approved these changes
Nov 10, 2026
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 11, 2026
Rollup of 9 pull requests Successful merges: - #165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims) - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #165750 (Wrap proc-macro `EscapeError` enum into a struct) - #164218 (Tweak private re-export errors to point at correct span and have more context) - #165021 (In irrefutable patterns, the FieldPat is skipped, which means the name: field is not printed) - #165537 (Canonicalization cleanups) - #165772 (Remove unnecessary mut from HirIdValidator::check_nested_id) - #165779 (make improper_ctypes accept `x87_f80`) - #165780 (std: map more errno values to ErrorKind on Hermit)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 11, 2026
Rollup merge of #165772 - yassa-tamer:remove-unnecessary-mut, r=JonathanBrouwer Remove unnecessary mut from HirIdValidator::check_nested_id Remove unnecessary `mut` from `HirIdValidator::check_nested_id`, as this method doesn't need a mutated self. See [#t-compiler/help > The check_nested_id in HirIdValidator doesn't need mut](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/The.20check_nested_id.20in.20HirIdValidator.20.20doesn.27t.20need.20mut/with/639210467) The changes compile successfully and pass the `./x check compiler/rustc_passes` check.
mehmettoplu-rs
pushed a commit
to mehmettoplu-rs/miri
that referenced
this pull request
Nov 13, 2026
Rollup of 9 pull requests Successful merges: - rust-lang/rust#165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims) - rust-lang/rust#165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - rust-lang/rust#165750 (Wrap proc-macro `EscapeError` enum into a struct) - rust-lang/rust#164218 (Tweak private re-export errors to point at correct span and have more context) - rust-lang/rust#165021 (In irrefutable patterns, the FieldPat is skipped, which means the name: field is not printed) - rust-lang/rust#165537 (Canonicalization cleanups) - rust-lang/rust#165772 (Remove unnecessary mut from HirIdValidator::check_nested_id) - rust-lang/rust#165779 (make improper_ctypes accept `x87_f80`) - rust-lang/rust#165780 (std: map more errno values to ErrorKind on Hermit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary
mutfromHirIdValidator::check_nested_id, as this method doesn't need a mutated self. See #t-compiler/help > The check_nested_id in HirIdValidator doesn't need mutThe changes compile successfully and pass the
./x check compiler/rustc_passescheck.