Repository navigation
Convert pretty-std debuginfo test to gdb-repr - #165939
Conversation
|
|
|
@bors try jobs=test-x86_64-mingw-1 |
This comment has been minimized.
This comment has been minimized.
Convert `pretty-std` debuginfo test to `gdb-repr` try-job: test-x86_64-mingw-1
| try: | ||
| from gdb.printing import make_visualizer | ||
| except: # noqa: E722 | ||
| # (Walnut356): The below was true for older versions of gdb I think? In newer versions, this |
There was a problem hiding this comment.
Oh wow. I never saw this hack. That's nasty.
There was a problem hiding this comment.
Every time I have to reach for importlib I rub my hands together like a dastardly villain lmao It's absolutely the most cursed module in python
|
Thank you! @bors r+ |
|
💔 I suspect this PR failed tests as part of a rollup After fixing the problem, consider running a try job for the failed job before re-approving. Link to failure: #165981 (comment) (specifically the test-various failure) |
|
This pull request was unapproved. This PR was contained in a rollup (#165981), which was unapproved. |
Yikes, that's a bit older than I was expecting. |
d3f31c3 to
64ee61f
Compare
|
@bors try jobs=test-various |
Convert `pretty-std` debuginfo test to `gdb-repr` try-job: test-various
This comment has been minimized.
This comment has been minimized.
|
💔 Test for ad67880 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
|
Hmm, looks like it was added in GDB 14. Fair enough. |
64ee61f to
008f8a5
Compare
|
@bors try jobs=test-various |
Convert `pretty-std` debuginfo test to `gdb-repr` try-job: test-various
This comment has been minimized.
This comment has been minimized.
|
Wait, so does that mean that the GDB visualizers won't work in GDB <14 anymore? GDB 14 was released in 2023, and we talked about supporting only a small set of debugger versions officially, but it would be good to acknowledge that explicitly. |
|
Nope, that limit is only a concession to the test suite itself. Alternatively, I could just pull their implementation into the test suite so that we don't rely on GDB's export of it anymore. |
|
Ah, I see. In that case it's fine. @bors r+ rollup=iffy |
Rollup of 15 pull requests Successful merges: - #166054 (stdarch subtree update) - #165939 (Convert `pretty-std` debuginfo test to `gdb-repr`) - #165289 (lexer: Update to Unicode 18) - #165960 (alloctests: use thread-local in `c_str_alloc_error`) - #166002 (#[optimize]: keep low opt levels unoptimized) - #166003 (Fix ICE in tail_expr_drop_order lint with async drops) - #166049 (rustc_target: Require altivec feature for ELFv2 powerpc64 targets) - #165200 (fix abi kind of thumb windows targets) - #165966 (Document failing cases for spawning processes when using Command) - #165999 (Update TPDE submodule) - #166045 (rustdoc: Correctly filter deref impls on type aliases) - #166063 (Fix bad hyperlink) - #166066 (Update books) - #166072 (simplify Appearances iter) - #166075 (Remove dead code emitting `UnusedBuiltinAttribute`)
View all comments
This also fixes a few minor bugs that this conversion revealed.
r? @Kobzol, @jieyouxu