Skip to content

Convert pretty-std debuginfo test to gdb-repr - #165939

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Walnut356:pretty_std_gdb
Nov 17, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Walnut356:pretty_std_gdb

Conversation

@Walnut356

@Walnut356 Walnut356 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

View all comments

This also fixes a few minor bugs that this conversion revealed.

r? @Kobzol, @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 13, 2026
@rustbot

rustbot commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@Walnut356

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-x86_64-mingw-1

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Nov 13, 2026
Convert `pretty-std` debuginfo test to `gdb-repr`


try-job: test-x86_64-mingw-1
@rust-bors

rust-bors Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 499074b (499074b67a0efaab65cb7854904bfcf38c7c9804)
Base parent: 6ca2b34 (6ca2b34602bf2f3591ffa7359c166b6409a44b0a)

try:
from gdb.printing import make_visualizer
except: # noqa: E722
# (Walnut356): The below was true for older versions of gdb I think? In newer versions, this

@Kobzol Kobzol Nov 14, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow. I never saw this hack. That's nasty.

View changes since the review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every time I have to reach for importlib I rub my hands together like a dastardly villain lmao It's absolutely the most cursed module in python

Comment thread tests/debuginfo/pretty-std/main.rs Resolved
@Kobzol

Kobzol commented Nov 14, 2026

Copy link
Copy Markdown
Member

Thank you!

@bors r+

@rust-bors

rust-bors Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d3f31c3 has been approved by Kobzol

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Reason for tree closure: consistent failures on main

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 14, 2026
Convert `pretty-std` debuginfo test to `gdb-repr`

This also fixes a few minor bugs that this conversion revealed.

r? @Kobzol, @jieyouxu
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 14, 2026
Convert `pretty-std` debuginfo test to `gdb-repr`

This also fixes a few minor bugs that this conversion revealed.

r? @Kobzol, @jieyouxu
@JonathanBrouwer

JonathanBrouwer commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #165981 (comment)

(specifically the test-various failure)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2026
@rust-bors

rust-bors Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#165981), which was unapproved.

View changes since this unapproval

@Walnut356

Copy link
Copy Markdown
Contributor Author

GNU gdb (Ubuntu 12.1-0ubuntu1~22.04.2) 12.1

Yikes, that's a bit older than I was expecting.

@Walnut356

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various

rust-bors Bot pushed a commit that referenced this pull request Nov 15, 2026
Convert `pretty-std` debuginfo test to `gdb-repr`


try-job: test-various
@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

💔 Test for ad67880 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@Walnut356

Copy link
Copy Markdown
Contributor Author

Hmm, looks like it was added in GDB 14. Fair enough.

@Walnut356

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various

rust-bors Bot pushed a commit that referenced this pull request Nov 15, 2026
Convert `pretty-std` debuginfo test to `gdb-repr`


try-job: test-various
@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 763037b (763037bbc0de57094e2ae5fd505e7ef17f08ff8f)
Base parent: 5f4effd (5f4effd579500175af844241eb179e756190f1e7)

@Kobzol

Kobzol commented Nov 16, 2026

Copy link
Copy Markdown
Member

Wait, so does that mean that the GDB visualizers won't work in GDB <14 anymore? GDB 14 was released in 2023, and we talked about supporting only a small set of debugger versions officially, but it would be good to acknowledge that explicitly.

@Walnut356

Copy link
Copy Markdown
Contributor Author

Nope, that limit is only a concession to the test suite itself. make_visualizer gives us a convenient surface area for debugger_tester to interact with types with visualizers and types without visualizers, but the scripts themselves don't use it.

Alternatively, I could just pull their implementation into the test suite so that we don't rely on GDB's export of it anymore.

@Kobzol

Kobzol commented Nov 16, 2026

Copy link
Copy Markdown
Member

Ah, I see. In that case it's fine.

@bors r+ rollup=iffy

@rust-bors

rust-bors Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 008f8a5 has been approved by Kobzol

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 17, 2026
Rollup of 15 pull requests

Successful merges:

 - #166054 (stdarch subtree update)
 - #165939 (Convert `pretty-std` debuginfo test to `gdb-repr`)
 - #165289 (lexer: Update to Unicode 18)
 - #165960 (alloctests: use thread-local in `c_str_alloc_error`)
 - #166002 (#[optimize]: keep low opt levels unoptimized)
 - #166003 (Fix ICE in tail_expr_drop_order lint with async drops)
 - #166049 (rustc_target: Require altivec feature for ELFv2 powerpc64 targets)
 - #165200 (fix abi kind of thumb windows targets)
 - #165966 (Document failing cases for spawning processes when using Command)
 - #165999 (Update TPDE submodule)
 - #166045 (rustdoc: Correctly filter deref impls on type aliases)
 - #166063 (Fix bad hyperlink)
 - #166066 (Update books)
 - #166072 (simplify Appearances iter)
 - #166075 (Remove dead code emitting `UnusedBuiltinAttribute`)
rust-bors Bot pushed a commit that referenced this pull request Nov 17, 2026
Rollup merge of #165939 - Walnut356:pretty_std_gdb, r=Kobzol

Convert `pretty-std` debuginfo test to `gdb-repr`

This also fixes a few minor bugs that this conversion revealed.

r? @Kobzol, @jieyouxu
@rust-bors
rust-bors Bot merged commit 4aafca5 into rust-lang:main Nov 17, 2026
15 checks passed
@rustbot rustbot added this to the 1.102.0 milestone Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants