Skip to content

Fix bad hyperlink - #166063

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
maxdexh:silence-rustdoc-this-isnt-my-code
Nov 17, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
maxdexh:silence-rustdoc-this-isnt-my-code

Conversation

@maxdexh

@maxdexh maxdexh commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Make it so x doc library doesn't fail due to a "this hyperlink is cringe" warning

@rustbot rustbot added A-slice-vec Area: `[T]` and `Vec<T>` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 16, 2026
@rustbot

rustbot commented Nov 16, 2026

Copy link
Copy Markdown
Collaborator

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 38 candidates
  • Random selection from ChrisDenton, JohnTitor, Mark-Simulacrum, clarfonthey, joboet

@maxdexh

maxdexh commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Current output on main

warning: this URL is not a hyperlink
 --> library/core/src/slice/sort/stable/tiny.rs:1:49
  |
1 | ...rgesort inspired by https://github.com/voultapher/tiny-sort-rs.
  |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: bare URLs are not automatically turned into clickable links
  = note: `#[warn(rustdoc::bare_urls)]` on by default
help: use an automatic link instead
  |
1 | //! Binary-size optimized mergesort inspired by <https://github.com/voultapher/tiny-sort-rs>.
  |                                                 +                                          +

@clarfonthey

Copy link
Copy Markdown
Contributor

Ah, I wonder if we should explicitly ensure these get checked in CI…

@maxdexh

maxdexh commented Nov 16, 2026

Copy link
Copy Markdown
Member Author

Probably, was surprised this wasn't

@clarfonthey

Copy link
Copy Markdown
Contributor

@bors r+ rollup

Filed #166067 for the general rustdoc lint enforcement, we'll just merge this for now.

@rust-bors

rust-bors Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

📌 Commit cabdeec has been tentatively approved by clarfonthey

It will be put into the queue for this repository once PR CI succeeds.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…my-code, r=clarfonthey

Fix bad hyperlink

Make it so `x doc library` doesn't fail due to a "this hyperlink is cringe" warning
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…my-code, r=clarfonthey

Fix bad hyperlink

Make it so `x doc library` doesn't fail due to a "this hyperlink is cringe" warning
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #166054 (stdarch subtree update)
 - #165289 (lexer: Update to Unicode 18)
 - #165960 (alloctests: use thread-local in `c_str_alloc_error`)
 - #166002 (#[optimize]: keep low opt levels unoptimized)
 - #166049 (rustc_target: Require altivec feature for ELFv2 powerpc64 targets)
 - #165200 (fix abi kind of thumb windows targets)
 - #165935 (Duplicate attribute diagnostic cleanups)
 - #165999 (Update TPDE submodule)
 - #166045 (rustdoc: Correctly filter deref impls on type aliases)
 - #166063 (Fix bad hyperlink)
 - #166066 (Update books)
 - #166072 (simplify Appearances iter)
 - #166075 (Remove dead code emitting `UnusedBuiltinAttribute`)
rust-bors Bot pushed a commit that referenced this pull request Nov 17, 2026
Rollup of 15 pull requests

Successful merges:

 - #166054 (stdarch subtree update)
 - #165939 (Convert `pretty-std` debuginfo test to `gdb-repr`)
 - #165289 (lexer: Update to Unicode 18)
 - #165960 (alloctests: use thread-local in `c_str_alloc_error`)
 - #166002 (#[optimize]: keep low opt levels unoptimized)
 - #166003 (Fix ICE in tail_expr_drop_order lint with async drops)
 - #166049 (rustc_target: Require altivec feature for ELFv2 powerpc64 targets)
 - #165200 (fix abi kind of thumb windows targets)
 - #165966 (Document failing cases for spawning processes when using Command)
 - #165999 (Update TPDE submodule)
 - #166045 (rustdoc: Correctly filter deref impls on type aliases)
 - #166063 (Fix bad hyperlink)
 - #166066 (Update books)
 - #166072 (simplify Appearances iter)
 - #166075 (Remove dead code emitting `UnusedBuiltinAttribute`)
@rust-bors
rust-bors Bot merged commit b55de26 into rust-lang:main Nov 17, 2026
14 checks passed
@rustbot rustbot added this to the 1.102.0 milestone Nov 17, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 17, 2026
Rollup merge of #166063 - maxdexh:silence-rustdoc-this-isnt-my-code, r=clarfonthey

Fix bad hyperlink

Make it so `x doc library` doesn't fail due to a "this hyperlink is cringe" warning
@maxdexh
maxdexh deleted the silence-rustdoc-this-isnt-my-code branch November 17, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-slice-vec Area: `[T]` and `Vec<T>` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants