Make null() and null_mut() const functions#28187
Merged
Merged
Conversation
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
We've been steadily rolling out cases like these. Thanks for the PR! @bors: r+ |
Collaborator
|
📌 Commit 06fb196 has been approved by |
Contributor
|
@bors: rollup |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 3, 2015
And replace more `0 as *const T`/`0 as *mut T`s with `null()`/`null_mut()`s I'm not sure what is the general policy about making simple functions `const`, but `null()` and `null_mut()` seem to be good candidates.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 3, 2015
And replace more `0 as *const T`/`0 as *mut T`s with `null()`/`null_mut()`s I'm not sure what is the general policy about making simple functions `const`, but `null()` and `null_mut()` seem to be good candidates.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 3, 2015
Contributor
|
Oh nice, this will be handy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And replace more
0 as *const T/0 as *mut Ts withnull()/null_mut()sI'm not sure what is the general policy about making simple functions
const, butnull()andnull_mut()seem to be good candidates.