-
Notifications
You must be signed in to change notification settings - Fork 64
Adapted complex exp() function so that it can handle inf and nan arguments as well #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
cde925f
Adapted exp() for complex numbers so that it correctly treats the cor…
JorisDeRidder 65db97b
Added unit tests for new version of exp() for complex numbers.
JorisDeRidder 6016691
Adapted unit tests for complex exp() to take advantage of the cis() f…
JorisDeRidder e650b31
Replaced Complex { re: xx, im: yy } with Complex::new(xx, yy) in modu…
JorisDeRidder 7813277
Added a https link in the inline docs of test_exp() referring to the …
JorisDeRidder a83b916
Formatting changes after running cargo fmt.
JorisDeRidder 07a1836
Made complex exp() more readable.
JorisDeRidder 02295f8
Fixed bug in close_naninf_to_tol() causing the real part comparison t…
JorisDeRidder f294b51
Merge branch 'master' of https://github.com/rust-num/num-complex
JorisDeRidder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't lose the
recomparison.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aargh, sorry about that... None of the unit tests caught this. I just fixed the bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, "Who tests the tester?" It could just
return true, and the unit tests would pass. :)