Conversation
|
Ah, yes, I forgot to open issues for this. We did it before in the |
cuviper
left a comment
cuviper
left a comment
There was a problem hiding this comment.
You'll need to update the CI scripts, updating the min to 1.13 (if we don't use derive) and removing the part that tests a downgrade to serde-0.7.
Cargo.toml
Outdated
|
|
||
| [features] | ||
| default = ["rustc-serialize"] | ||
| default = ["serde"] |
There was a problem hiding this comment.
I don't think we need this to be in the default features.
| Ok(Complex::new(re, im)) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I would prefer to keep the same manual impl, just updated for the newer API.
|
I've fix using
|
|
Great, thanks! I may tweak that minimum version, but it's fine for now. I'm not sure when I'll be ready to start merging changes for 0.2, but I'll use this PR when I do. |
We'll probably have rand to test soon too.
|
Rebased -- thanks again! bors r+ |
Build succeeded |
2 participants
serde-1.0 should be the default serialization option since rustc-serialize is already obsolete.
Note: This is a breaking change. We need to bump up the version to 0.2.