Merged
Conversation
0198a07 to
c5deb21
Compare
|
Travis still has a |
Author
Did I miss something else? :-) |
|
Rust 1.8 isn't supported anymore. Serde needs 0.13 I think (at least that's what our travis checks) |
Author
EDIT2: I'm on Gitter if you want, on #rust-num/num according to weechat. |
Author
|
Seems like I had forgot a file. |
Author
|
Seem to pass now. Is there a reason though, to still support 1.13? |
Member
|
I consider it a breaking change to bump the minimum rust, so please don't
remove 1.8 testing entirely here. Just add 1.13 to CI as the minimum for
using serde.
(Even though we *are* making a breaking change here, let's isolate that
change to serde for the moment.)
|
cuviper
requested changes
Jun 21, 2017
bigint/Cargo.toml
Outdated
| [dependencies.serde] | ||
| optional = true | ||
| version = ">= 0.7.0, < 0.9.0" | ||
| version = ">= 1.0.0, < 2.0.0" |
Member
There was a problem hiding this comment.
Please make this a simple "1.0" dependency.
9d3f49f to
e079033
Compare
cuviper
approved these changes
Jun 22, 2017
Member
|
Thanks! |
This was referenced Dec 20, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W.r.t. #302 & #218, I took the arrow to the knee and started changing what needed changing.
TODO:Done; that was quicker than I thought.Did I miss more
serdestuff?