Set settings screen size to same minimum width#1428
Set settings screen size to same minimum width#1428edwinish wants to merge 2 commits intorxhanson:mainfrom
Conversation
|
Thanks for working on this! In its current state, I'm not quite on board to merge. This is mainly because the pane on the gear tab is not ready for the increased width, but also for some reason I kind of dislike the additional width on the snapping tab, too. It can be nontrivial to get everything looking great with this type of adjustment, and maybe it's finally worth considering putting all of the shortcuts in one column. Honestly any route that feels desirable to me is enough effort that I had considered waiting until a time when I could rewrite it in SwiftUI and make it look prettier in general, with an updated shortcut recorder (which of course snowballs into a whole lot of effort and part of why the UI has stayed the way it is). An interim approach that I would be more inclined to merge would be re-doing the toolbar to position the toolbar items next to the red-yellow-green buttons (using a flexible spacer to the right). We wouldn't get the fixed width, but the more glaring issue of the toolbar items moving around would be fixed. |
|
Thank you for the feed back. I agree I see the concern with the issue on the sizing of the gear tab. I will attempt the other interim fix and see how that goes. |
This reverts commit ca4b3cb.
|
Apologies, I spent sometime on it but I am not too familiar with with the storyboard. Or not sure if I can align the tab view to the left side. It seems the tab view is limited but I may be wrong. I will close this and maybe look for other bug I might be able to help solve. Thank you for your time. |
|
No worries, it's not a trivial change (which is why I haven't already made it myself :) I appreciate your time regardless. |
Hello,
Submitting this pull request in reference to this bug.
#1353 (comment)
It does not update to the new way Apple recommends. It addresses "Also a bit cumbersome is the fact that the window size changes so much between the different panes.".
I just set the minimum size of the "Settings View Controller Scene", "Snap Area View Controller" to 732, which is the size of the biggest "Prefs View Controller".
Screenshot of settings I changed.

Screencapture of settings.
https://github.com/user-attachments/assets/da77c40d-aefa-4f84-9f39-ff1f903ee65c
Let me know if you have any questions or concerns.