fix(tvdb): respect display language when fetching metadata#1889
Merged
fallenbagel merged 8 commits intoseerr-team:developfrom Sep 8, 2025
Merged
fix(tvdb): respect display language when fetching metadata#1889fallenbagel merged 8 commits intoseerr-team:developfrom
fallenbagel merged 8 commits intoseerr-team:developfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
TOomaAh
force-pushed
the
fix/tvdb-display-language-ignored
branch
from
a5535a3 to
86b3b87
Compare
gauthier-th
requested changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshot (if UI-related)
To-Dos
pnpm buildpnpm i18n:extractIssues Fixed or Closed
I verified the translation mapping by using the file 'src/context/LanguageContext.tsx' as a source for TMDB and mapping each language to those provided by TVDB by calling the route 'https://api4.thetvdb.com/v4/languages' (I can provide the call result).
The translation retrieval is working. When doing a partial translation of a series, no name is retrieved for the episode that is not translated.
I've re-added the line that was accidentally deleted, which was indeed preventing language retrieval.
To fetch TVDB translations, I need to call an API that returns paginated results. This API returns pages of 500 elements. To limit API calls somewhat, when the requested language matches the series' language, I retrieve all seasons corresponding to the series to reduce the number of calls.
For translation retrieval, I've added a fallback language (English). If neither the requested language nor the fallback language is available, the original translation (from the series' country of origin) is retrieved.