Skip to content

fix(setup): fix Plex login not proceeding after authentication#2290

Merged
gauthier-th merged 1 commit intodevelopfrom
fallenbagel/fix/plex-login-popup-revalidate
Jan 11, 2026
Merged

fix(setup): fix Plex login not proceeding after authentication#2290
gauthier-th merged 1 commit intodevelopfrom
fallenbagel/fix/plex-login-popup-revalidate

Conversation

@fallenbagel
Copy link
Copy Markdown
Collaborator

Directly fetch and populate SWR cache with user data instead of relying on revalidate() which is disabled on auth pages since #2213

fix #2288

Description

Fixed an issue in the setup flow where completing Plex authentication in the popup wouldn't automatically proceed to the next step. This was caused by a recent change (#2213) that disabled SWR revalidation on auth pages, which meant the revalidate() call after login wasn't actually fetching user data. The fix directly fetches the user data and populates the SWR cache.

How Has This Been Tested?

  • Choose Plex as a login
  • Login with plex

Screenshots / Logs (if applicable)

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Directly fetch and populate SWR cache with user data instead of relying on revalidate() which is
disabled on auth pages since #2213

fix #2288
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a bug in the Plex authentication flow during the setup process. After a recent change that disabled SWR revalidation on auth pages, calling revalidate() without arguments no longer fetched user data. The fix directly fetches user data via the /api/v1/auth/me endpoint and populates the SWR cache by passing it to revalidate().

Changes:

  • Modified the Plex login handler to fetch user data explicitly after authentication
  • Updated revalidate() call to pass the fetched user data and disable automatic revalidation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@0xSysR3ll 0xSysR3ll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauthier-th gauthier-th merged commit 4ab9193 into develop Jan 11, 2026
14 checks passed
@gauthier-th gauthier-th deleted the fallenbagel/fix/plex-login-popup-revalidate branch January 11, 2026 17:43
0xSysR3ll pushed a commit to 0xSysR3ll/jellyseerr that referenced this pull request Jan 20, 2026
…-team#2290)

Directly fetch and populate SWR cache with user data instead of relying on revalidate() which is
disabled on auth pages since seerr-team#2213

fix seerr-team#2288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

During Initial Setup > Sign In, After logging in with Plex account, it does not progress to step #3 automatically

4 participants