feat: add tvdb indexer by TOomaAh · Pull Request #899 · seerr-team/seerr

TOomaAh · 2024-07-26T23:10:28Z

Description

Available to test as preview-tvdb.

Screenshot (if UI-related)

To-Dos

Successful build pnpm build
Translation keys pnpm i18n:extract
Database migration (if required)

Issues Fixed or Closed

Fixes #XXXX

server/routes/settings/tvdb.ts

github-actions · 2024-08-07T11:49:09Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

DjordyKoert · 2024-10-19T20:07:14Z

Any update on this feature? 👀

I think this would help with the issue described here #648

TOomaAh · 2024-10-19T20:19:05Z

Any update on this feature? 👀

I think this would help with the issue described here #648

Sorry, I've got a lot of work at the moment but I've continued to work on it, I'm trying to use directly the api that sonarr uses, skyhook.

server/routes/settings/tvdb.ts

gauthier-th · 2024-10-26T20:54:22Z

Looks like half of the tests are failing. Could you take a look and try to fix them? And add some for TVDB?

TOomaAh · 2024-10-27T10:31:12Z

Looks like half of the tests are failing. Could you take a look and try to fix them? And add some for TVDB?

Hello, indeed, I solved the problem of the existing tests and I added tests for tvdb.

gauthier-th

I didn't go into detail, but the overall looks good.
I'll make a more in-depth review later.

server/api/indexer/themoviedb/index.ts

server/lib/settings/index.ts

server/routes/settings/tvdb.ts

github-actions · 2024-11-03T06:37:32Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

gauthier-th · 2024-11-17T21:51:36Z

This can be tested with the preview-tvdb-indexer tag.

gauthier-th · 2024-11-17T21:57:43Z

@TOomaAh next time you should rebase instead of merge. Merging makes the history look messy.

It's also in our contributing guide to rebase instead of merging

github-actions · 2024-11-20T23:05:03Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

server/api/indexer/themoviedb/index.ts

markus101 · 2025-01-19T19:39:40Z

Hey @TOomaAh, I'm one of the Sonarr devs and this PR was recently brought to my attention.

I see that this is using Skyhook for TheTVDB data; our agreement with TheTVDB is for Skyhook to be hosted for Sonarr's direct use only and cannot be used with other applications as it's being used here.

fallenbagel · 2025-02-16T14:07:34Z

@TOomaAh could you also remove the tvdb apikey setting? We will add a global one (i will personally commit it to this pr so just put a placeholder for now)

The reasoning for this decision can be found here:
#1250 (comment)

gauthier-th

Overall looks good! Nice work 😉

There are some inconsistencies with the naming of the metadata indexer (sometimes "Indexer", sometime "Metadata Provider", sometimes "Provider", etc.).
IMO we should stick with "Metadata Provider" everywhere, to avoid the possible confusion with the "Indexer" term and to stay explicit.

src/i18n/locale/fr.json

server/lib/scanners/jellyfin/index.ts

server/routes/settings/metadata.ts

src/components/MetadataSelector/index.tsx

src/components/Settings/SettingsMetadata.tsx

server/api/tvdb/index.ts

src/components/Settings/SettingsLayout.tsx

…a Providers"

…der"

samirbilalmemon · 2025-08-30T17:05:34Z

@TOomaAh I would love to test this out, how can I proceed? I have been wanting to have a requestor that matches the same data I see on Sonarr.

TOomaAh · 2025-08-30T17:22:43Z

@TOomaAh I would love to test this out, how can I proceed? I have been wanting to have a requestor that matches the same data I see on Sonarr.

Hello,

Normally you just have to follow these instructions: https://docs.jellyseerr.dev/getting-started/buildfromsource

tests are failing, I'll solve the problem

veselin-antonov · 2025-08-31T00:27:10Z

Is the preview docker image up-to-date with the latest changes?

veselin-antonov · 2025-08-31T03:18:17Z

Also, what language is used for the request to the TVDB API? Is there a setting for this, is some existing setting being used or is it just not being passed?

TOomaAh · 2025-08-31T22:16:34Z

Is the preview docker image up-to-date with the latest changes?

No, the image is four months old: https://hub.docker.com/r/fallenbagel/jellyseerr/tags?name=preview-tvdb

gauthier-th · 2025-09-01T12:28:24Z

I just updated the preview tag: preview-tvdb. Will be available in ~30min.

config/db/.gitkeep

gauthier-th

LGTM, tested and everything seems fine!

veselin-antonov · 2025-09-02T03:24:57Z

server/routes/tv.ts

+    const season = await metadataProvider.getTvSeason({
      tvId: Number(req.params.id),
      seasonNumber: Number(req.params.seasonNumber),
-      language: (req.query.language as string) ?? req.locale,


I am guessing that this change is the reason that now the episode names come in the original language of the show instead of the display language of the user (ex. Sakamoto Days - Japanese instead of Emglish):

Current version:

TVDB Preview:

Same settings, just the docker image tag is changed between the screenshot. Maybe it is was unintentional, maybe it has a reason, I so not know but I think it should be looked into.

Should I open a new GitHub issue with this problem?

Yes please.

The issue is #1888

github-advanced-security bot found potential problems Jul 26, 2024

View reviewed changes

server/routes/settings/tvdb.ts Fixed Show fixed Hide fixed

fallenbagel changed the title ~~Feat add tvdb indexer~~ feat: add tvdb indexer Jul 27, 2024

github-actions bot added the merge conflict Cannot merge due to merge conflicts label Aug 7, 2024

github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Oct 19, 2024

github-advanced-security bot found potential problems Oct 20, 2024

View reviewed changes

server/routes/settings/tvdb.ts Fixed Show fixed Hide fixed

gauthier-th marked this pull request as ready for review October 28, 2024 21:30

gauthier-th requested review from fallenbagel and gauthier-th as code owners October 28, 2024 21:30

gauthier-th reviewed Oct 28, 2024

View reviewed changes

server/api/indexer/themoviedb/index.ts Show resolved Hide resolved

server/lib/settings/index.ts Outdated Show resolved Hide resolved

server/routes/settings/tvdb.ts Outdated Show resolved Hide resolved

github-actions bot added merge conflict Cannot merge due to merge conflicts and removed merge conflict Cannot merge due to merge conflicts labels Nov 3, 2024

gauthier-th added the preview PRs deployed for testing with tag `:preview-prxx` label Nov 17, 2024

github-actions bot added the merge conflict Cannot merge due to merge conflicts label Nov 20, 2024

TOomaAh force-pushed the feat-add-tvdb-indexer branch from 2ee5535 to f447870 Compare December 12, 2024 00:55

github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Dec 12, 2024

fallenbagel requested changes Dec 12, 2024

View reviewed changes

server/api/indexer/themoviedb/index.ts Show resolved Hide resolved

gauthier-th mentioned this pull request Dec 30, 2024

Prioritize TVDB Over TMDB for TV Show and Anime Resources #1204

Closed

1 task

TOomaAh force-pushed the feat-add-tvdb-indexer branch 2 times, most recently from 0fe1827 to 353d079 Compare January 15, 2025 17:43

TOomaAh added 2 commits August 23, 2025 00:36

fix(test): fix test with default provider tmdb anime

ac24c37

style(cypress): fix anime name variable

7814fff

TOomaAh force-pushed the feat-add-tvdb-indexer branch from a50524a to 7814fff Compare August 22, 2025 22:37

github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Aug 22, 2025

gauthier-th requested changes Aug 28, 2025

View reviewed changes

TOomaAh added 6 commits August 28, 2025 23:12

chore(i18n): remove french translation + apply i18n:extract

61b764b

style(wording): standardize naming to "Metadata Provider" in UI text

04c22ef

docs(comments): translate from French to English

04f0506

refactor(tvdb): remove unnecessary try/catch block

be3454c

feat(i18n): add missing translations

c0cc109

fix(scanner): correct metadata provider ID from Tmdb to Tvdb

ca52a3e

TOomaAh commented Aug 28, 2025

View reviewed changes

src/components/Settings/SettingsLayout.tsx Outdated Show resolved Hide resolved

TOomaAh added 2 commits August 29, 2025 00:51

style(settings): clarify navigation label from "Metadata" to "Metadat…

9c072e4

…a Providers"

style(logs): update error log label from "Metadata" to "MetadataProvi…

82d81fd

…der"

refactor(tvdb): replace indexer by metadata providers

d7655e5

refactor(settings): remove metadata providers logo

668a6ae

gauthier-th requested changes Sep 2, 2025

View reviewed changes

config/db/.gitkeep Show resolved Hide resolved

fix(config): restore missing config/db/.gitkeep file

d02b022

gauthier-th approved these changes Sep 2, 2025

View reviewed changes

fallenbagel approved these changes Sep 2, 2025

View reviewed changes

gauthier-th merged commit 22b2824 into seerr-team:develop Sep 2, 2025
8 checks passed

veselin-antonov reviewed Sep 3, 2025

View reviewed changes

veselin-antonov mentioned this pull request Sep 3, 2025

Display language not being taken into account with TVDB metadata provider #1888

Closed

1 task

0xSysR3ll mentioned this pull request Oct 16, 2025

Add new Metadata Source #2055

Closed

1 task

Uh oh!

Conversation

TOomaAh commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshot (if UI-related)

To-Dos

Issues Fixed or Closed

Uh oh!

Uh oh!

github-actions bot commented Aug 7, 2024

Uh oh!

DjordyKoert commented Oct 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TOomaAh commented Oct 19, 2024

Uh oh!

Uh oh!

gauthier-th commented Oct 26, 2024

Uh oh!

TOomaAh commented Oct 27, 2024

Uh oh!

gauthier-th left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 3, 2024

Uh oh!

gauthier-th commented Nov 17, 2024

Uh oh!

gauthier-th commented Nov 17, 2024 • edited by fallenbagel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 20, 2024

Uh oh!

Uh oh!

markus101 commented Jan 19, 2025

Uh oh!

fallenbagel commented Feb 16, 2025

Uh oh!

gauthier-th left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samirbilalmemon commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TOomaAh commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

veselin-antonov commented Aug 31, 2025

Uh oh!

veselin-antonov commented Aug 31, 2025

Uh oh!

TOomaAh commented Aug 31, 2025

Uh oh!

gauthier-th commented Sep 1, 2025

Uh oh!

Uh oh!

gauthier-th left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

veselin-antonov Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

veselin-antonov Sep 3, 2025

TOomaAh commented Jul 26, 2024 •

edited

Loading

DjordyKoert commented Oct 19, 2024 •

edited

Loading

gauthier-th commented Nov 17, 2024 •

edited by fallenbagel

Loading

samirbilalmemon commented Aug 30, 2025 •

edited

Loading

TOomaAh commented Aug 30, 2025 •

edited

Loading

veselin-antonov Sep 2, 2025 •

edited

Loading