Fix Client restricted categories in the Sample add view form#2734
Draft
Bugerman58 wants to merge 27 commits into
Draft
Fix Client restricted categories in the Sample add view form#2734Bugerman58 wants to merge 27 commits into
Bugerman58 wants to merge 27 commits into
Conversation
ramonski
reviewed
May 29, 2025
Contributor
Author
|
this PR is currently on pause because there was an upgrade earlier with the removal of the I'm looking into it... |
Contributor
|
Hi Anton, is this still an issue or fixed already in recent versions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
TODO comment from
Clientcontent type: Fix Client restricted categories are not considered in Add sampleCurrent behavior before PR
Does not impose a limitation on the choice of services when adding an Sample if the client has a limitation on categories
Desired behavior after PR is merged
Services cannot be selected if they are not contained in the Client categories
☝️Additional: For fasted getting Category title was be added columngetCategoryTitleto metadata for Setup catalog--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.