Fix profile services are not applied when creating samples programmatically#2736
Merged
Merged
Conversation
Contributor
|
Hi Ramon! I encountered this in #2734 when I was researching about creating an the Sample outside of the add form(jsonapi example). |
Contributor
Author
Hi Anton, Yes, in fact I also encountered this error while working with the JSON API again. Regarding #2734: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR fixes a side effect that was introduced in #2672
The problem arises if samples are created programmatically via the
bika.lims.utils.analysisrequest.create_analysisrequesthelper and not via the sample add form (where we already have these profile services extracted).Current behavior before PR
Profile services are not added during sample creation if created programmatically.
Desired behavior after PR is merged
Profile services are added during sample creation if created programmatically.
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.