Fix non-executable execution with input option#212
Merged
sindresorhus merged 5 commits intosindresorhus:masterfrom May 7, 2019
Merged
Fix non-executable execution with input option#212sindresorhus merged 5 commits intosindresorhus:masterfrom
input option#212sindresorhus merged 5 commits intosindresorhus:masterfrom
Conversation
ehmicky
reviewed
May 6, 2019
ehmicky
requested changes
May 6, 2019
Collaborator
ehmicky
left a comment
ehmicky
left a comment
There was a problem hiding this comment.
Looks good except for comment about styling consistency with other tests.
Collaborator
|
Thanks for this PR @stroncium! This issue was reported with #166. There is an ongoing fix within Node.js here: nodejs/node#26852 However for current and older Node.js versions, we should definitely use that check, i.e. looks good to me. Just need @sindresorhus review as well before merging. |
ehmicky
approved these changes
May 6, 2019
sindresorhus
reviewed
May 6, 2019
sindresorhus
changed the title
input option
This was referenced May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execathrows internal error instead of rejecting with proper error when running non-executable with input.fixes #166
Failing test: https://travis-ci.org/sindresorhus/execa/builds/528756511?utm_source=github_status&utm_medium=notification
Added test, fixed the problem.