Skip to content

Fix non-executable execution with input option #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sindresorhus merged 5 commits into from
May 7, 2019
Merged

Fix non-executable execution with input option #212

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b53e9d9
failing test
stroncium May 6, 2019
a1db3bd
fix
stroncium May 6, 2019
7ffa191
saving code lines
stroncium May 6, 2019
121843d
comment
stroncium May 7, 2019
6bf248f
Update index.js
sindresorhus May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ function handleArgs(command, args, options = {}) {
}

function handleInput(spawned, input) {
if (input === undefined) {
if (input === undefined || spawned.stdin === undefined) {
Comment thread
stroncium marked this conversation as resolved.
return;
}

Expand Down
6 changes: 6 additions & 0 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,12 @@ if (process.platform !== 'win32') {
const cp = execa('non-executable');
await t.throwsAsync(cp);
});

test('execa() rejects with correct error and doesn\'t throw if running non-executable with input', async t => {
await t.throwsAsync(() => {
Comment thread
ehmicky marked this conversation as resolved.
Outdated
return execa('non-executable', {input: 'Hey!'});
}, /EACCES/);
});
}

test('error.killed is true if process was killed directly', async t => {
Expand Down