fix(iOS): Prevent delay when dismissing transparentModals#3189
Merged
kmichalikk merged 3 commits intomainfrom Sep 9, 2025
Merged
fix(iOS): Prevent delay when dismissing transparentModals#3189kmichalikk merged 3 commits intomainfrom
kmichalikk merged 3 commits intomainfrom
Conversation
kligarski
approved these changes
Sep 3, 2025
kkafar
reviewed
Sep 8, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
I've noticed that despite not scheduling animation callback we still receive "progress notification" when animation: 'none' is set:
Could you give me some context of how is this achieved? I do not get it instantly from reading the diff.
Member
|
Okay, I've found, that we emit 0.0 & 1.0 transition progress in |
Member
|
I've opened diff against this PR. #3205. If you want, land it or apply these manually / start discussion about these changes. |
If the transition is not animated, we do not need to set up the animation & completion callback.
kmichalikk
force-pushed
the
@kmichalikk/animation-duration-transparent-modal-3074
branch
from
434c86e to
2cf2d6a
Compare
kmichalikk
deleted the
@kmichalikk/animation-duration-transparent-modal-3074
branch
satya164
added a commit
to react-navigation/react-navigation
that referenced
this pull request
Oct 30, 2025
Docs update to match changes in react-native-screens software-mansion/react-native-screens#3189. **Motivation** In RN Screens, we fixed the bug with delay when dismissing full screen modals, and updated the docs for `transitionDuration` to reflect that we don't support customizing it for modals. This PR adds matching change to `animationDuration` doc. --------- Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
satya164
added a commit
to react-navigation/react-navigation
that referenced
this pull request
Oct 30, 2025
Docs update to match changes in react-native-screens software-mansion/react-native-screens#3189. **Motivation** In RN Screens, we fixed the bug with delay when dismissing full screen modals, and updated the docs for `transitionDuration` to reflect that we don't support customizing it for modals. This PR adds matching change to `animationDuration` doc. --------- Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
satya164
added a commit
to react-navigation/react-navigation
that referenced
this pull request
Nov 1, 2025
Docs update to match changes in react-native-screens software-mansion/react-native-screens#3189. **Motivation** In RN Screens, we fixed the bug with delay when dismissing full screen modals, and updated the docs for `transitionDuration` to reflect that we don't support customizing it for modals. This PR adds matching change to `animationDuration` doc. --------- Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #3074.
This PR removes the delay when dismissing fullscreen modal-like screens. This behavior can be observed on native apps, but makes things look as if they are broken. We also observe that modal screens don't take transitionDuration into account. We don't plan on supporting it now, but might look into it in the future. Docs are updated to reflect the current state.
Testing
Use Test3074. It has 4 screens in stack - 1. and 2. are a regular screen, 3. & 4. are transparentModals. The last one should dismiss immediately without animation. Revert changes in RNSScreen to see the bug. Checking Debug/Slow animations in simulator makes it even more apparent.