Closed
Conversation
If the transition is not animated, we do not need to set up the animation & completion callback.
kkafar
changed the base branch from
main
to
@kmichalikk/animation-duration-transparent-modal-3074
kmichalikk
force-pushed
the
@kmichalikk/animation-duration-transparent-modal-3074
branch
from
434c86e to
2cf2d6a
Compare
Base automatically changed from
@kmichalikk/animation-duration-transparent-modal-3074
to
main
September 9, 2025 08:16
Contributor
|
Added to #3189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suggested review changes for #3189.
See discussion under #3189 for reasoning.
Changes
Test code and steps to reproduce
Checklist