secrets: Allow using secrets from os.Environ #872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a requirement for secrets. The inline comment explains a bit why this is okay. This is all it takes from the src-cli side to implement secrets support :)
Piszmog
approved these changes
Oct 19, 2022
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
This is a requirement for secrets. The inline comment explains a bit why this is okay. This is all it takes from the src-cli side to implement secrets support :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a requirement for secrets. The inline comment explains a bit why this is okay. This is all it takes from the src-cli side to implement secrets support :)
Test plan
Tested E2E locally with the new secrets backend.