Skip to content

secrets: Allow using secrets from os.Environ #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eseliger merged 1 commit into from
Oct 19, 2022
Merged

secrets: Allow using secrets from os.Environ #872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cmd/src/batch_exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,14 +185,17 @@ func executeBatchSpecInWorkspaces(ctx context.Context, flags *executorModeFlags)
}
ui.PreparingContainerImagesSuccess()

// Empty for now until we support secrets or env var settings in SSBC.
var globalEnv []string

// Set up the execution UI.
taskExecUI := ui.ExecutingTasks(false, 1)
taskExecUI.Start([]*executor.Task{task})
taskExecUI.TaskStarted(task)

// Pass the os.Environ to run steps to allow access to the secrets set
// in the executor environment.
// The executor runtime takes care of not forwarding any sensitive secrets
// from the host, so this is safe.
globalEnv := os.Environ()

opts := &executor.RunStepsOpts{
Logger: &log.NoopTaskLogger{},
WC: workspace.NewExecutorWorkspaceCreator(tempDir, repoDir),
Expand Down