Fix Spanner write mutation coder serialization#5919
Open
NA-V10 wants to merge 1 commit intospotify:mainfrom
Open
Fix Spanner write mutation coder serialization#5919NA-V10 wants to merge 1 commit intospotify:mainfrom
NA-V10 wants to merge 1 commit intospotify:mainfrom
Conversation
Author
|
Thanks for reporting this issue. I updated the Spanner write path to explicitly use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change explicitly sets
spannerMutationCoderon theSCollection[Mutation]before applying the Beam Spanner write transform.Previously, the write path relied on Beam/Kryo fallback serialization, which could lead to
UnsupportedOperationExceptionwhen serializingMutation/MutationGroup.Changes Made
spannerMutationCoderusingCoderMaterializer.beamSCollection[Mutation]data.setCoder(coder).applyInternal(transform)Why
A
spannerMutationCoderalready exists inCoderInstances, but it was not being explicitly used inSpannerWrite. This change ensures that Beam uses the intended serializer forMutationobjects during writes.