Skip to content

Fix Spanner write mutation coder serialization #5919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NA-V10 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −7
Open

Fix Spanner write mutation coder serialization #5919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions scio-google-cloud-platform/src/main/scala/com/spotify/scio/spanner/SpannerIO.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,17 @@ final case class SpannerWrite(config: SpannerConfig) extends SpannerIO[Mutation]
override type WriteP = SpannerWrite.WriteParam

override protected def write(data: SCollection[Mutation], params: WriteP): Tap[Nothing] = {
val transform = BSpannerIO
.write()
.withSpannerConfig(config)
.withBatchSizeBytes(params.batchSizeBytes)
.withFailureMode(params.failureMode)
val coder = CoderMaterializer.beam(data.context, coders.spannerMutationCoder)

val transform = BSpannerIO
.write()
.withSpannerConfig(config)
.withBatchSizeBytes(params.batchSizeBytes)
.withFailureMode(params.failureMode)

data.applyInternal(transform)
data.setCoder(coder).applyInternal(transform)
EmptyTap
}
}

override protected def read(sc: ScioContext, params: ReadP): SCollection[Mutation] = sc.wrap {
throw new UnsupportedOperationException("SpannerWrite is write-only")
Expand Down