Makefile: Disable Make's implict suffix rules

[WardBrian]

Summary

These rules can cause some very unintuitive behavior, see: https://www.gnu.org/software/make/manual/html_node/Implicit-Rules.html

Hopefully we aren't relying on them anywhere, I'm counting on Jenkins to tell me if so...

Tests

None

Side Effects

None 🤞🏻

Release notes

Disabled Make's implicit rules in our Makefiles.

Checklist

• Copyright holder: (fill in copyright holder information)

  The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
  - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
  - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

• the basic tests are passing

  • unit tests pass (to run, use: ./runTests.py test/unit)
  • header checks pass, (make test-headers)
  • dependencies checks pass, (make test-math-dependencies)
  • docs build, (make doxygen)
  • code passes the built in C++ standards checks (make cpplint)

• the code is written in idiomatic C++ and changes are documented in the doxygen

• the new changes are tested

[syclik]

Unfortunately, I think we rely on a lot of implicit rules. My guess is that we’re going to have to remove the rule from .r to whatever object file instead of the proposed fix on this PR.

…

On Thu, May 8, 2025 at 9:44 AM Brian Ward ***@***.***> wrote: Summary These rules can cause some very unintuitive behavior, see: https://www.gnu.org/software/make/manual/html_node/Implicit-Rules.html Hopefully we aren't relying on them anywhere, I'm counting on Jenkins to tell me if so... Tests None Side Effects None 🤞🏻 Release notes Disabled Make's implicit rules in our Makefiles. Checklist - Copyright holder: (fill in copyright holder information) The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses: - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause) - Documentation: CC-BY 4.0 ( https://creativecommons.org/licenses/by/4.0/) - the basic tests are passing - unit tests pass (to run, use: ./runTests.py test/unit) - header checks pass, (make test-headers) - dependencies checks pass, (make test-math-dependencies) - docs build, (make doxygen) - code passes the built in C++ standards <https://github.com/stan-dev/stan/wiki/Coding-Style-and-Idioms> checks (make cpplint) - the code is written in idiomatic C++ and changes are documented in the doxygen - the new changes are tested ------------------------------ You can view, comment on, or merge this pull request online at: #3183 Commit Summary - 2b5ddc2 <2b5ddc2> Makefile: Disable Make's implict suffix rules File Changes (1 file <https://github.com/stan-dev/math/pull/3183/files>) - *M* make/compiler_flags <https://github.com/stan-dev/math/pull/3183/files#diff-97ba75bfaa6bf58dfe81971aaeff146e80b4c628a130c312278687500ce94287> (7) Patch Links: - https://github.com/stan-dev/math/pull/3183.patch - https://github.com/stan-dev/math/pull/3183.diff — Reply to this email directly, view it on GitHub <#3183>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADH6F6UZ25SLIXCP3CDX4D25NNUBAVCNFSM6AAAAAB4WR57XCVHI2DSMVQWIX3LMV43ASLTON2WKOZTGA2DSMBVGQ4TGNY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[WardBrian]

It appears the only implicit rule we really depend on is the one for turning a .cpp file into a .o file in our tests. We could avoid that if we wanted to, but it seems like a relatively harmless entry to keep.

[stan-buildbot]

---

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
eight_schools/eight_schools.stan	0.05	0.06	0.97	-2.6% slower
pkpd/one_comp_mm_elim_abs.stan	18.53	19.23	0.96	-3.78% slower
pkpd/sim_one_comp_mm_elim_abs.stan	0.24	0.25	0.96	-4.14% slower
arK/arK.stan	1.72	1.79	0.96	-3.99% slower
gp_pois_regr/gp_pois_regr.stan	2.66	2.81	0.95	-5.37% slower
gp_regr/gen_gp_data.stan	0.02	0.03	0.93	-7.01% slower
gp_regr/gp_regr.stan	0.09	0.1	0.93	-7.18% slower
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	8.33	9.37	0.89	-12.47% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan	2.64	2.89	0.91	-9.51% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.01	0.01	0.93	-7.31% slower
garch/garch.stan	0.4	0.46	0.87	-15.1% slower
arma/arma.stan	0.3	0.36	0.85	-18.12% slower
irt_2pl/irt_2pl.stan	3.92	4.59	0.85	-17.02% slower
sir/sir.stan	66.18	72.41	0.91	-9.4% slower
performance.compilation	178.87	179.74	1.0	-0.48% slower
Mean result: 0.9260097383634668

---

Jenkins Console Log
Blue Ocean
Commit hash: 1d627cef879710563a572fa3a668b4d9e1137422

---

Machine information

No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 3446.770
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: Split huge pages
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS; IBPB conditional; STIBP conditional; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

[syclik]

LGTM