Skip to content

Makefile: Disable Make's implict suffix rules #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WardBrian merged 4 commits into from
May 9, 2025
Merged

Makefile: Disable Make's implict suffix rules #3183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b5ddc2
Makefile: Disable Make's implict suffix rules
WardBrian May 8, 2025
eb4d188
Add back .cc for googletest
WardBrian May 8, 2025
f7cc08a
Just define a rule for gtest-all.o
WardBrian May 8, 2025
b029119
.cpp for tests
WardBrian May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions make/compiler_flags
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,13 @@ CXX_VERSION := $(shell $(CXX) -dumpfullversion -dumpversion 2>&1)
CXX_MAJOR := $(word 1,$(subst ., ,$(CXX_VERSION)))
CXX_MINOR := $(word 2,$(subst ., ,$(CXX_VERSION)))

# disable Make's implicit suffix rules
# see: https://www.gnu.org/software/make/manual/html_node/Implicit-Rules.html
# this should make Make slightly faster, as well as avoiding some unexpected
# behavior when there are other files lying around with the same name as
# Stan models
.SUFFIXES: .cpp

################################################################################
# Set optional compiler flags for performance
#
Expand Down
7 changes: 2 additions & 5 deletions make/libraries
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,11 +252,8 @@ endif
############################################################
# Google Test:
# Build the google test library.
$(GTEST)/src/gtest-all.o: CXXFLAGS += $(CXXFLAGS_GTEST)
$(GTEST)/src/gtest-all.o: CPPFLAGS += $(CPPFLAGS_GTEST)
$(GTEST)/src/gtest-all.o: INC += $(INC_GTEST)


$(GTEST)/src/gtest-all.o: $(GTEST)/src/gtest-all.cc
$(COMPILE.cpp) -x c++ $(CXXFLAGS_GTEST) $(CPPFLAGS_GTEST) $(INC_GTEST) -o $@ -c $<

############################################################
# Clean all libraries
Expand Down