Fix empty timestamp handling in ISO deserialization#324
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
Fix empty timestamp handling in ISO deserialization#324github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Treat empty strings for created_at/expires_at as provided values so isoformat parsing runs and raises DeserializationError for invalid timestamps. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Raise deserialization errors for empty ISO
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SerializationAdapter.load_dict()to treatcreated_atandexpires_atas present when they are empty stringsDeserializationErroron invalid values, including""created_atandexpires_atare rejectedChanges
src/key_value/aio/_utils/serialization.pyis not Nonechecks forcreated_atandexpires_attests/utils/test_serialization.pytest_rejects_empty_isoformat_datetimeparameterized for both fieldsValidation
python -m uv run pytest tests/utils/test_serialization.py -qmake test-conciseFixes [bug-hunter] Serialization accepts empty created_at/expires_at instead of raising deserialization error #320