Skip to content

Fix empty timestamp handling in ISO deserialization #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix empty timestamp handling in ISO deserialization #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/key_value/aio/_utils/serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ def load_dict(self, data: dict[str, Any]) -> ManagedEntry:
if self._date_format in ("isoformat", "datetime"):
expected_type = str if self._date_format == "isoformat" else datetime
parser = parse_datetime_str if self._date_format == "isoformat" else (lambda value: value)
if created_at := key_must_be(data, key="created_at", expected_type=expected_type):
if (created_at := key_must_be(data, key="created_at", expected_type=expected_type)) is not None:
managed_entry_proto["created_at"] = parser(created_at)
if expires_at := key_must_be(data, key="expires_at", expected_type=expected_type):
if (expires_at := key_must_be(data, key="expires_at", expected_type=expected_type)) is not None:
managed_entry_proto["expires_at"] = parser(expires_at)

if "value" not in data:
Expand Down
7 changes: 7 additions & 0 deletions tests/utils/test_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import pytest
from inline_snapshot import snapshot

from key_value.aio.errors import DeserializationError
from key_value.aio._utils.managed_entry import ManagedEntry
from key_value.aio._utils.serialization import BasicSerializationAdapter

Expand Down Expand Up @@ -80,3 +81,9 @@ def test_entry_two(self, adapter: BasicSerializationAdapter):

assert adapter.load_dict(data=adapter.dump_dict(entry=TEST_ENTRY_TWO)) == snapshot(TEST_ENTRY_TWO)
assert adapter.load_json(json_str=adapter.dump_json(entry=TEST_ENTRY_TWO)) == snapshot(TEST_ENTRY_TWO)

@pytest.mark.parametrize("field", ["created_at", "expires_at"])
def test_rejects_empty_isoformat_datetime(self, adapter: BasicSerializationAdapter, field: str) -> None:
payload = {"value": {"x": 1}, field: ""}
with pytest.raises(DeserializationError):
adapter.load_dict(data=payload)