Conversation
billyb2
force-pushed
the
block_metrics_non_interactive
branch
2 times, most recently
from
6109787 to
03422a6
Compare
Contributor
Author
|
|
billyb2
force-pushed
the
block_metrics_non_interactive
branch
from
07d1d4e to
e091d5c
Compare
billyb2
force-pushed
the
block_metrics_non_interactive
branch
3 times, most recently
from
3e8ff0e to
341a56f
Compare
The alternative is that metrics are never sent on CI, which is bad of course. There's still a timeout of at most 15 seconds, so worst case this won't block deploys for a considerable length of time.
billyb2
force-pushed
the
block_metrics_non_interactive
branch
from
341a56f to
b4069c2
Compare
billyb2
force-pushed
the
block_metrics_non_interactive
branch
from
b4069c2 to
546ecad
Compare
billyb2
force-pushed
the
block_metrics_non_interactive
branch
5 times, most recently
from
6a74d23 to
81f1b7a
Compare
billyb2
force-pushed
the
block_metrics_non_interactive
branch
from
81f1b7a to
117c4ab
Compare
rugwirobaker
reviewed
Nov 2, 2023
| ) | ||
|
|
||
| func setSysProcAttributes(cmd *exec.Cmd) { | ||
| func SetSysProcAttributes(cmd *exec.Cmd) { |
Contributor
There was a problem hiding this comment.
I feel like these should go into a new package in internal sys or something
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alternative is that metrics are never sent on CI, which is bad of course. There's still a timeout of at most 15 seconds, so worst case this won't block deploys for a considerable length of time.
Change Summary
What and Why:
How:
Related to:
Documentation