-
Notifications
You must be signed in to change notification settings - Fork 290
Ensure metrics are collected in non-interactive environments #4247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
clouvet
merged 6 commits into
master
from
collect-metrics-in-non-interactive-environments
Mar 15, 2025
Merged
Ensure metrics are collected in non-interactive environments #4247
clouvet
merged 6 commits into
master
from
collect-metrics-in-non-interactive-environments
Mar 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbjohnson
requested changes
Mar 10, 2025
c8bcd8b to
d38af0a
Compare
benbjohnson
approved these changes
Mar 13, 2025
Contributor
benbjohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall, just one comment
benbjohnson
approved these changes
Mar 14, 2025
clouvet
added a commit
that referenced
this pull request
Mar 15, 2025
3 tasks
clouvet
added a commit
that referenced
this pull request
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
This change fixes metrics not being sent in non-interactive sessions. The previous version of
SendMetricswas failing in non-interactive environments because it was using the original context directly with HTTP requests, which could be canceled before metrics were successfully sent, resulting in abandoned requests and lost metrics data.How:
The fix modifies the metrics system to:
SendMetricswith proper HTTP request handling, error management, and response body cleanupThis ensures metrics are sent successfully in both interactive and non-interactive modes, with detailed logging for troubleshooting.
Related to:
#2974
Documentation