Add scrollbar-gutter-* utilities#20018
Conversation
Confidence Score: 5/5Safe to merge — the change is additive, experimental-gated, and all affected snapshots are updated. The new utilities are minimal static declarations with correct CSS values, gated behind the same experimental flag as the rest of the scrollbar utilities. The property-order additions explain all snapshot ordering changes, tests cover valid and invalid inputs, and no existing behavior is modified. No files require special attention. Reviews (4): Last reviewed commit: "Add `scrollbar-width` and `scrollbar-col..." | Re-trigger Greptile |
| 'scrollbar-gutter', | ||
|
|
||
| 'list-style-position', |
There was a problem hiding this comment.
The other
scrollbar-* CSS properties (scrollbar-width and scrollbar-color) are used by the already-existing scrollbar-auto/thin/none and scrollbar-thumb/track utilities but are absent from this file. While that's a pre-existing gap, touching this file is a good opportunity to add them for consistent sort ordering across all scrollbar utilities.
| 'scrollbar-gutter', | |
| 'list-style-position', | |
| 'scrollbar-gutter', | |
| 'scrollbar-width', | |
| 'scrollbar-color', | |
| 'list-style-position', |
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThis PR adds support for the CSS 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
…20019) This PR adds the `scrollbar-width` and `scrollbar-color` properties to the property order list such that we have a stable sort order for these properties. I put `scrollbar-width` before `scrollbar-color`, which is the same order as the `border-width` and `border-color` properties. ## Test plan 1. Had to update a test because of the swapped order 2. All other tests pass
aa9a310 to
d2225f1
Compare
This PR adds new
scrollbar-gutter-*utilities. The API looks like this:scrollbar-gutter-autoscrollbar-gutter: autoscrollbar-gutter-stablescrollbar-gutter: stablescrollbar-gutter-bothscrollbar-gutter: stable both-edges