Skip to content

Add scrollbar-width and scrollbar-color to property order list#20019

Merged
RobinMalfait merged 4 commits intofeat/add-scrollbar-gutterfrom
fix/add-scrollbar-property-order
May 7, 2026
Merged

Add scrollbar-width and scrollbar-color to property order list#20019
RobinMalfait merged 4 commits intofeat/add-scrollbar-gutterfrom
fix/add-scrollbar-property-order

Conversation

@RobinMalfait
Copy link
Copy Markdown
Member

This PR adds the scrollbar-width and scrollbar-color properties to the property order list such that we have a stable sort order for these properties.

I put scrollbar-width before scrollbar-color, which is the same order as the border-width and border-color properties.

Test plan

  1. Had to update a test because of the swapped order
  2. All other tests pass

@RobinMalfait RobinMalfait requested a review from a team as a code owner May 7, 2026 08:49
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a531a21e-f7c5-4ef9-8850-b2efd3963722

📥 Commits

Reviewing files that changed from the base of the PR and between 12eb5ae and b1a2848.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • packages/tailwindcss/src/compat/config.test.ts
  • packages/tailwindcss/src/compat/plugin-api.test.ts
  • packages/tailwindcss/src/property-order.ts

Walkthrough

This PR updates the CSS property ordering to include scrollbar-width and scrollbar-color properties after existing scroll-padding properties. The property ordering contract in property-order.ts is updated to reflect this new position. Correspondingly, test snapshots in config.test.ts and plugin-api.test.ts are revised to verify that generated CSS rules now follow this updated property order, with scrollbar-related rules appearing in their new positions. The changelog is updated to explicitly document the scrollbar utility categories affected by this property ordering change.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding scrollbar-width and scrollbar-color properties to the property order list, which aligns with the actual modifications in property-order.ts and related test updates.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding the two properties to the property order list, the ordering rationale, and providing a test plan that matches the changes made.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 7, 2026

Confidence Score: 5/5

Safe to merge — the change is a minimal list insertion with no logic changes.

The only code change is inserting two string entries into a static property-order array, and the test snapshots have been updated to match the resulting sort output. The placement is internally consistent with the existing pattern of grouping related properties and ordering width before color.

No files require special attention.

Reviews (2): Last reviewed commit: "Merge branch 'feat/add-scrollbar-gutter'..." | Re-trigger Greptile

@RobinMalfait RobinMalfait changed the base branch from main to feat/add-scrollbar-gutter May 7, 2026 08:53
@RobinMalfait RobinMalfait merged commit aa9a310 into feat/add-scrollbar-gutter May 7, 2026
7 checks passed
@RobinMalfait RobinMalfait deleted the fix/add-scrollbar-property-order branch May 7, 2026 08:55
RobinMalfait added a commit that referenced this pull request May 8, 2026
…20019)

This PR adds the `scrollbar-width` and `scrollbar-color` properties to
the property order list such that we have a stable sort order for these
properties.

I put `scrollbar-width` before `scrollbar-color`, which is the same
order as the `border-width` and `border-color` properties.

## Test plan

1. Had to update a test because of the swapped order
2. All other tests pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant