Add scrollbar-width and scrollbar-color to property order list#20019
Merged
RobinMalfait merged 4 commits intofeat/add-scrollbar-gutterfrom May 7, 2026
Merged
Add scrollbar-width and scrollbar-color to property order list#20019RobinMalfait merged 4 commits intofeat/add-scrollbar-gutterfrom
scrollbar-width and scrollbar-color to property order list#20019RobinMalfait merged 4 commits intofeat/add-scrollbar-gutterfrom
Conversation
Contributor
Contributor
Confidence Score: 5/5Safe to merge — the change is a minimal list insertion with no logic changes. The only code change is inserting two string entries into a static property-order array, and the test snapshots have been updated to match the resulting sort output. The placement is internally consistent with the existing pattern of grouping related properties and ordering width before color. No files require special attention. Reviews (2): Last reviewed commit: "Merge branch 'feat/add-scrollbar-gutter'..." | Re-trigger Greptile |
RobinMalfait
added a commit
that referenced
this pull request
May 8, 2026
…20019) This PR adds the `scrollbar-width` and `scrollbar-color` properties to the property order list such that we have a stable sort order for these properties. I put `scrollbar-width` before `scrollbar-color`, which is the same order as the `border-width` and `border-color` properties. ## Test plan 1. Had to update a test because of the swapped order 2. All other tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
scrollbar-widthandscrollbar-colorproperties to the property order list such that we have a stable sort order for these properties.I put
scrollbar-widthbeforescrollbar-color, which is the same order as theborder-widthandborder-colorproperties.Test plan