Skip to content

fix(stream): fix memory leak in vtable data merge#33194

Merged
guanshengliang merged 2 commits into
mainfrom
fix/TD-38209-main
Oct 14, 2025
Merged

fix(stream): fix memory leak in vtable data merge#33194
guanshengliang merged 2 commits into
mainfrom
fix/TD-38209-main

Conversation

@JinqingKuang

Copy link
Copy Markdown
Contributor

Description

fix(stream): fix memory leak in vtable data merge

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@CLAassistant

CLAassistant commented Oct 14, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a memory leak in vtable data merge by adding proper cleanup code for allocated column data.

  • Adds memory cleanup code to prevent leaks in the vtable merger
  • Includes additional logic for handling delayed requests in stream trigger processing
  • Updates debug flags and logging levels for better debugging

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
test/cases/41-StreamProcessing/20-UseCase/test_idmp_meters.py Updates debug flag level from 131 to 135
source/libs/new-stream/src/streamTriggerTask.c Adds delayed request processing logic with proper cleanup
source/libs/new-stream/src/streamTriggerMerger.c Fixes memory leak by adding colData cleanup code
source/dnode/vnode/src/vnd/vnodeStream.c Changes logging level from DLOG to TLOG

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread source/libs/new-stream/src/streamTriggerMerger.c
Comment thread source/libs/new-stream/src/streamTriggerTask.c
@guanshengliang guanshengliang merged commit 80d6713 into main Oct 14, 2025
10 of 12 checks passed
@guanshengliang guanshengliang deleted the fix/TD-38209-main branch October 14, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants