fix(stream): fix memory leak in vtable data merge#33194
Merged
guanshengliang merged 2 commits intomainfrom Oct 14, 2025
Merged
Conversation
ae4a416 to
6702815
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a memory leak in vtable data merge by adding proper cleanup code for allocated column data.
- Adds memory cleanup code to prevent leaks in the vtable merger
- Includes additional logic for handling delayed requests in stream trigger processing
- Updates debug flags and logging levels for better debugging
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/cases/41-StreamProcessing/20-UseCase/test_idmp_meters.py | Updates debug flag level from 131 to 135 |
| source/libs/new-stream/src/streamTriggerTask.c | Adds delayed request processing logic with proper cleanup |
| source/libs/new-stream/src/streamTriggerMerger.c | Fixes memory leak by adding colData cleanup code |
| source/dnode/vnode/src/vnd/vnodeStream.c | Changes logging level from DLOG to TLOG |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dapan1121
approved these changes
Oct 14, 2025
guanshengliang
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix(stream): fix memory leak in vtable data merge
Checklist
Please check the items in the checklist if applicable.