Skip to content

fix(stream): fix memory leak in vtable data merge #33194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guanshengliang merged 2 commits into from
Oct 14, 2025
Merged

fix(stream): fix memory leak in vtable data merge #33194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9131026
fix(stream): fix memory leak in vtable data merge
JinqingKuang Oct 10, 2025
6702815
fix(stream): awake trigger if able to send new calc request
JinqingKuang Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/dnode/vnode/src/vnd/vnodeStream.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,7 +1192,7 @@ static int32_t scanSubmitTbData(SVnode* pVnode, SDecoder *pCoder, SStreamTrigger
} else {
colId = -1;
}
ST_TASK_DLOG("%s vtable colId:%d, i:%d, uid:%" PRId64, __func__, colId, i, submitTbData.uid);
ST_TASK_TLOG("%s vtable colId:%d, i:%d, uid:%" PRId64, __func__, colId, i, submitTbData.uid);
} else {
colId = pColData->info.colId;
}
Expand Down
4 changes: 4 additions & 0 deletions source/libs/new-stream/src/streamTriggerMerger.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2105,6 +2105,10 @@ int32_t stNewVtableMergerNextDataBlock(SSTriggerNewVtableMerger *pMerger, SSData
*pEndIdx = nrows;

_end:
if (p != NULL) {
colDataDestroy(p);
taosMemoryFreeClear(p);
}
if (TSDB_CODE_SUCCESS != code) {
ST_TASK_ELOG("%s failed at line %d since %s", __func__, lino, tstrerror(code));
}
Expand Down
24 changes: 24 additions & 0 deletions source/libs/new-stream/src/streamTriggerTask.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5204,6 +5204,30 @@ static int32_t stRealtimeContextProcCalcRsp(SSTriggerRealtimeContext *pContext,
// continue check if the context is waiting for any available request
code = stRealtimeContextCheck(pContext);
QUERY_CHECK_CODE(code, lino, _end);
} else if (!pTask->lowLatencyCalc && pContext->pMaxDelayHeap->min != NULL &&
pContext->status == STRIGGER_CONTEXT_IDLE) {
// continue check if there are delayed requests to be processed
SSTriggerRealtimeGroup *pMinGroup = container_of(pContext->pMaxDelayHeap->min, SSTriggerRealtimeGroup, heapNode);
if (pMinGroup->nextExecTime > taosGetTimestampNs()) {
SListIter iter = {0};
SListNode *pNode = NULL;
taosWLockLatch(&gStreamTriggerWaitLatch);
tdListInitIter(&gStreamTriggerWaitList, &iter, TD_LIST_FORWARD);
while ((pNode = tdListNext(&iter)) != NULL) {
StreamTriggerWaitInfo *pInfo = (StreamTriggerWaitInfo *)pNode->data;
if (pInfo->streamId == pTask->task.streamId && pInfo->taskId == pTask->task.taskId &&
pInfo->sessionId == pContext->sessionId) {
TD_DLIST_POP(&gStreamTriggerWaitList, pNode);
break;
}
}
taosWUnLockLatch(&gStreamTriggerWaitLatch);
if (pNode != NULL) {
taosMemoryFreeClear(pNode);
code = stRealtimeContextCheck(pContext);
QUERY_CHECK_CODE(code, lino, _end);
}
}
}
} else {
code = tdListAppend(&pContext->retryCalcReqs, &pReq);
Expand Down
2 changes: 1 addition & 1 deletion test/cases/41-StreamProcessing/20-UseCase/test_idmp_meters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def test_stream_usecase_em(self):
# main test
#

tdSql.execute(f"alter all dnodes 'debugflag 131';")
tdSql.execute(f"alter all dnodes 'debugflag 135';")

# env
tdStream.createSnode()
Expand Down
Loading