Repository navigation
fix(external_velocity_limit_selector): use max_vel when no sender has… - #3628
Merged
kotaro-hihara merged 3 commits intoOct 20, 2026
Conversation
… set a limit An empty clear was published as max_velocity 0 because hardest_limit_ stayed at its default. Initialize it from max_vel so departure is not blocked. Co-authored-by: Cursor <cursoragent@cursor.com>
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
…te subscribers The output QoS is volatile and trajectory_modifier starts after this node, so the configured max_vel never reached ExternalVelocityLimit. Co-authored-by: Cursor <cursoragent@cursor.com>
A volatile one-shot publish is missed by trajectory_modifier, so publish max_vel once as transient_local and match that durability on the subscribers. Co-authored-by: Cursor <cursoragent@cursor.com>
N-Eiki
approved these changes
Oct 20, 2026
|
❌ The last analysis has failed. |
kotaro-hihara
deleted the
fix/v4.4.0.1-hotfix/external_velocity_limit_initial_max_vel
branch
October 20, 2026 11:46
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport
tier4/pilot_auto_planning#14
An empty clear was published as max_velocity 0 because hardest_limit_ stayed at its default. Initialize it from max_vel so departure is not blocked.
slack