Replace deprecated Sidekiq testing API with new Sidekiq 8.1+ API#1011
Open
mattmenefee wants to merge 1 commit intotoptal:masterfrom
Open
Replace deprecated Sidekiq testing API with new Sidekiq 8.1+ API#1011mattmenefee wants to merge 1 commit intotoptal:masterfrom
mattmenefee wants to merge 1 commit intotoptal:masterfrom
Conversation
mattmenefee
force-pushed
the
replace-deprecated-sidekiq-testing-API
branch
3 times, most recently
from
6d31f1a to
37bfad4
Compare
`require "sidekiq/testing"` is deprecated and will be removed in
Sidekiq 9.0. The new API makes test mode activation explicit:
- `require 'sidekiq/testing'` → `Sidekiq.testing!(:fake)`
- `Sidekiq::Testing.inline! { }` → `Sidekiq.testing!(:inline) { }`
Centralize the fake mode activation in spec_helper.rb rather than
repeating it in each spec file, and silence the Sidekiq logger
during test runs to reduce noise.
Co-authored-by: Matt Jankowski <matt@jankowski.online>
mattmenefee
force-pushed
the
replace-deprecated-sidekiq-testing-API
branch
from
37bfad4 to
0ae9636
Compare
Contributor
Author
|
Apologies @mjankowski! I didn't see #999 before opening this PR. I've updated this to incorporate your approach (centralized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sidekiq.testing!(:fake)inspec_helper.rbinstead of repeatingrequire 'sidekiq/testing'in each spec fileSidekiq::Testing.inline!blocks withSidekiq.testing!(:inline)blocksBuilds on the approach from #999 (centralized setup + logger silencing) and adds the
Sidekiq::Testing.inline!migration that PR didn't cover.Test plan
bundle exec rspec spec/chewy/strategy/sidekiq_spec.rb spec/chewy/strategy/lazy_sidekiq_spec.rb spec/chewy/strategy/delayed_sidekiq_spec.rb spec/chewy/strategy/delayed_sidekiq/scheduler_spec.rb spec/chewy/strategy/delayed_sidekiq/worker_spec.rb)Sidekiq::TestingAPI